|Summary:||testRunner.setWindowIsKey() has no effect on the web process side in WebKit2|
|Component:||Tools / Tests||Assignee:||Daniel Bates <dbates>|
|Status:||RESOLVED CONFIGURATION CHANGED|
|Severity:||Normal||CC:||andersca, dbates, pnormand, sam, webkit-bug-importer|
|Version:||528+ (Nightly build)|
Description mitz 2012-03-20 21:19:23 PDT
The WebKitTestRunner implementation of LayoutTestController.setWindowIsKey merely sets a flag on the window in the UI process, but changes nothing on the web process side. In particular, this makes it ineffective for fast/events/blur-focus-window-should-blur-focus-element.html.
Comment 2 mitz 2012-03-20 21:24:03 PDT
Added fast/events/blur-focus-window-should-blur-focus-element.html to the WebKit2 skip list in <http://trac.webkit.org/r111495>.
Comment 3 mitz 2012-03-20 21:34:36 PDT
Added fast/selectors/selection-window-inactive.html to the WebKit2 skip list in <http://trac.webkit.org/r111496>.
Comment 4 Martin Robinson 2015-05-08 16:19:36 PDT
*** Bug 79757 has been marked as a duplicate of this bug. ***
Comment 6 Daniel Bates 2015-05-29 12:50:17 PDT
Comment on attachment 253903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253903&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:-425 > - bool isViewWindowActive() const; Removed this since there is no implementation for this function. Will add remark in change log.
Comment 7 mitz 2015-05-29 12:52:07 PDT
I am not sure this is the right way to go here. Can’t we integrate this into the existing view-state updating mechanism?
Comment 8 Sam Weinig 2015-05-29 13:41:08 PDT
(In reply to comment #7) > I am not sure this is the right way to go here. Can’t we integrate this into > the existing view-state updating mechanism? I agree. Adding more SPI here does not seem necessary.
Comment 9 Daniel Bates 2018-02-26 11:31:18 PST
Forward dup'ing to bug #149325, which fixed this bug. *** This bug has been marked as a duplicate of bug 149325 ***
Comment 10 Daniel Bates 2018-02-26 11:36:53 PST
(In reply to Daniel Bates from comment #9) > Forward dup'ing to bug #149325, which fixed this bug. > > *** This bug has been marked as a duplicate of bug 149325 *** I lied. Bug #149325 was fixed this issue for iOS. It did not fix it for Mac and fast/events/blur-focus-window-should-blur-focus-element.html is still failing. Some other change has at least ameliorated this bug on Mac such that the test fast/selectors/selection-window-inactive.html now passes in WebKit2.
Comment 11 Daniel Bates 2018-02-26 11:38:52 PST
Code analogous to the code in the patch for bug #149325 was added for Mac in the patch for bug #167997.
Comment 12 Daniel Bates 2018-02-26 13:17:25 PST
Although the original reported test fast/events/blur-focus-window-should-blur-focus-element.html is still failing, I am marking this bug as fixed because the original premise for the failure has been fixed on Mac and iOS. That is, the WebKitTestRunner implementation of TestRunner::setWindowIsKey() now actually updates the window activation state on Mac and iOS following the fixes in <https://trac.webkit.org/changeset/189959> (bug #149325) and <http://trac.webkit.org/changeset/211910> (bug #167997). Filed bug #183139 to track fixing the test failure fast/events/blur-focus-window-should-blur-focus-element.html. We still need to fix testRunner.setWindowIsKey() on GTK on WPE. Filed bug #183143 to track fixing this issue for GTK. Filed bug #183144 to track fixing this issue for WPE.