Bug 81736 – testRunner.setWindowIsKey() has no effect on the web process side in WebKit2

• Component: Tools / Tests
• Status: RESOLVED CONFIGURATION CHANGED

The WebKitTestRunner implementation of LayoutTestController.setWindowIsKey merely sets a flag on the window in the UI process, but changes nothing on the web process side. In particular, this makes it ineffective for fast/events/blur-focus-window-should-blur-focus-element.html.

[Radar WebKit Bug Importer]

<rdar://problem/11088268>

Added fast/events/blur-focus-window-should-blur-focus-element.html to the WebKit2 skip list in <http://trac.webkit.org/r111495>.

Added fast/selectors/selection-window-inactive.html to the WebKit2 skip list in <http://trac.webkit.org/r111496>.

[Martin Robinson]

*** Bug 79757 has been marked as a duplicate of this bug. ***

[Daniel Bates]

Created attachment 253903 [details]
Patch

[Daniel Bates]

Comment on attachment 253903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253903&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:-425
> -    bool isViewWindowActive() const;

Removed this since there is no implementation for this function. Will add remark in change log.

I am not sure this is the right way to go here. Can’t we integrate this into the existing view-state updating mechanism?

[Sam Weinig]

(In reply to comment #7)
> I am not sure this is the right way to go here. Can’t we integrate this into
> the existing view-state updating mechanism?

I agree. Adding more SPI here does not seem necessary.

[Daniel Bates]

Forward dup'ing to bug #149325, which fixed this bug.

*** This bug has been marked as a duplicate of bug 149325 ***

[Daniel Bates]

(In reply to Daniel Bates from comment #9)
> Forward dup'ing to bug #149325, which fixed this bug.
> 
> *** This bug has been marked as a duplicate of bug 149325 ***

I lied. Bug #149325 was fixed this issue for iOS. It did not fix it for Mac and fast/events/blur-focus-window-should-blur-focus-element.html is still failing. Some other change has at least ameliorated this bug on Mac such that the test fast/selectors/selection-window-inactive.html now passes in WebKit2.

[Daniel Bates]

Code analogous to the code in the patch for bug #149325 was added for Mac in the patch for bug #167997.

[Daniel Bates]

Although the original reported test fast/events/blur-focus-window-should-blur-focus-element.html is still failing, I am marking this bug as fixed because the original premise for the failure has been fixed on Mac and iOS. That is, the WebKitTestRunner implementation of TestRunner::setWindowIsKey() now actually updates the window activation state on Mac and iOS following the fixes in <https://trac.webkit.org/changeset/189959> (bug #149325) and <http://trac.webkit.org/changeset/211910> (bug #167997).

Filed bug #183139 to track fixing the test failure fast/events/blur-focus-window-should-blur-focus-element.html.

We still need to fix testRunner.setWindowIsKey() on GTK on WPE. Filed bug #183143 to track fixing this issue for GTK. Filed bug #183144 to track fixing this issue for WPE.

[Daniel Bates]

Committed r229041: <https://trac.webkit.org/changeset/229041>