Bug 81726

Summary: [BlackBerry] Remove redundant code in SocketStreamHandler
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: Charles Wei <charles.wei>
Status: RESOLVED FIXED    
Severity: Normal CC: jonathan.dong.webkit, leo.yang, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch to remove redundant code in SocketStreamHandle none

Charles Wei
Reported 2012-03-20 19:46:48 PDT
platform/network/blackberry/SocketStreamHandle.h void didReceiveAuthenticationChallenge(const AuthenticationChallenge&); void receivedCredential(const AuthenticationChallenge&, const Credential&); void receivedRequestToContinueWithoutCredential(const AuthenticationChallenge&); void receivedCancellation(const AuthenticationChallenge&); are not needed and not called from anywhere, with empty implementation. Need to remove them since that's what MAC and CURL network porting uses, we use different mechanism for authentication.
Attachments
Patch to remove redundant code in SocketStreamHandle (3.67 KB, patch)
2012-03-20 19:56 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-03-20 19:56:54 PDT
Created attachment 132951 [details] Patch to remove redundant code in SocketStreamHandle
Charles Wei
Comment 2 2012-03-20 20:03:49 PDT
Internal: 145049
WebKit Review Bot
Comment 3 2012-03-21 00:30:16 PDT
Comment on attachment 132951 [details] Patch to remove redundant code in SocketStreamHandle Clearing flags on attachment: 132951 Committed r111507: <http://trac.webkit.org/changeset/111507>
WebKit Review Bot
Comment 4 2012-03-21 00:30:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.