Summary: | [chromium] Convert TouchFlingPlatformGestureCurve to a 2-D Bezier for better control of curve shape. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | W. James MacLean <wjmaclean> | ||||
Component: | New Bugs | Assignee: | W. James MacLean <wjmaclean> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | davemoore, enne, jamesr, rjkroege, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
W. James MacLean
2012-03-20 16:14:48 PDT
Created attachment 132924 [details]
Patch
(In reply to comment #1) > Created an attachment (id=132924) [details] > Patch The patch to rename this class will follow (maybe tomorrow morning at this point). Comment on attachment 132924 [details]
Patch
Unofficially LGTM. Does @davemoore <3 this?
Comment on attachment 132924 [details]
Patch
stylistically the patch looks fine; normally I wouldn't touch a patch in this area with a ten foot pole, but nduca says it looks good ...
(In reply to comment #3) > (From update of attachment 132924 [details]) > Unofficially LGTM. Does @davemoore <3 this? Yes, Dave has seen and thought it was good (not to speak for him of course!). Rob and Alex and I are happier with it than any of the other candidates - it feels pretty good. Comment on attachment 132924 [details] Patch Clearing flags on attachment: 132924 Committed r111483: <http://trac.webkit.org/changeset/111483> All reviewed patches have been landed. Closing bug. |