Summary: | Sandboxed PluginProcess should use private temporary and cache directories | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2012-03-20 14:46:47 PDT
Created attachment 132904 [details]
proposed patch
Comment on attachment 132904 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:107 > + static char temporaryDirectory[PATH_MAX]; Why static? Comment on attachment 132904 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review >> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:107 >> + static char temporaryDirectory[PATH_MAX]; > > Why static? No good reason. Will remove. Comment on attachment 132904 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=132904&action=review > Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:105 > + String systemDirectorySuffix = "com.apple.WebKit.PluginProcess+" + PluginProcess::shared().pluginBundleIdentifier(); I think you should just call PluginProcess::shared().netscapePluginModule()->module()->bundleIdentifier(); directly here. Committed <http://trac.webkit.org/changeset/111463>. |