Bug 81696

Summary:

REGRESSION (r97596): Enabling :visited in layout test is not compatible with running arbitrary subsets of tests in arbitrary order

Product:

WebKit

Reporter:

mitz

Component:

Tools / Tests

Assignee:

mitz

Status:

NEW

Severity:

Normal

CC:

eric, ggaren, kling, koivisto, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar, LayoutTestFailure, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Work around test failures caused by this issue in some fast/block tests	jberlin: review+

mitz

Reported 2012-03-20 13:46:27 PDT

<http://trac.webkit.org/r97596> made render tree dumps expose visited link styling. When using run-webkit-tests, which URLs are visited when a given test is run is arbitrary (it depends on things such as the number of instances of the test program running, the number of tests before a given test, and the subset of tests being run), so results are inconsistent.

Attachments
Work around test failures caused by this issue in some fast/block tests (12.82 KB, patch) 2012-03-20 14:05 PDT, mitz	jberlin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2012-03-20 13:47:28 PDT

<rdar://problem/11084564>

mitz

Comment 2 2012-03-20 14:05:36 PDT

Created attachment 132892 [details] Work around test failures caused by this issue in some fast/block tests

Jessie Berlin

Comment 3 2012-03-20 14:17:38 PDT

Comment on attachment 132892 [details] Work around test failures caused by this issue in some fast/block tests On IRC, Dan assured me that there are no other platform-specific or cross platform results that need to be updated.

mitz

Comment 4 2012-03-20 14:20:06 PDT

Committed attachment 132892 [details] as in <http://trac.webkit.org/r111437>.

mitz

Comment 5 2012-03-24 10:15:25 PDT

fast/block/float/float-in-float-hit-testing.html is another test affected by this

mitz

Comment 6 2012-03-24 10:20:58 PDT

(In reply to comment #5) > fast/block/float/float-in-float-hit-testing.html is another test affected by this although the problem there seems to be inconsistency between DumpRenderTree and WebKitTestRunner.

Eric Seidel (no email)

Comment 7 2012-03-27 12:34:09 PDT

Attachment 132892 [details] was posted by a committer and has review+, assigning to Dan Bernstein for commit.

mitz

Comment 8 2012-03-27 13:14:25 PDT

(In reply to comment #7) > Attachment 132892 [details] was posted by a committer and has review+, assigning to Dan Bernstein for commit. See comment #4, which states specifically the attachment and the revision in which it was committed.

Eric Seidel (no email)

Comment 9 2012-03-27 13:16:00 PDT

It's just my automated script, assigning patches to committers if they're in the commit queue. I assume that since this has been committed it should be closed?

Eric Seidel (no email)

Comment 10 2012-03-27 13:16:30 PDT

Or alternatively, we should obsolete the above patch now that its' been landed (since I assume you're waiting for hte actual regression to be fixed?)

Eric Seidel (no email)

Comment 11 2012-03-27 13:17:24 PDT

(None of this is a big deal. Just explaining why the scripts (and people) see this patch as being in the pending-commit list.)

Note You need to log in before you can comment on or make changes to this bug.