Summary: | Incremental cleanup of BitmapImage: inlined virtual functions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tom Hudson <tomhudson> | ||||||
Component: | Images | Assignee: | Tom Hudson <tomhudson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jamesr, senorblanco, simon.fraser, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tom Hudson
2012-03-20 11:57:09 PDT
Created attachment 132870 [details]
Patch
Attachment 132870 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/BitmapImage.cpp:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 132878 [details]
Patch
Comment on attachment 132878 [details]
Patch
OK
Comment on attachment 132878 [details] Patch Clearing flags on attachment: 132878 Committed r111572: <http://trac.webkit.org/changeset/111572> All reviewed patches have been landed. Closing bug. |