Bug 81688

Summary: Incremental cleanup of BitmapImage: inlined virtual functions
Product: WebKit Reporter: Tom Hudson <tomhudson>
Component: ImagesAssignee: Tom Hudson <tomhudson>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, senorblanco, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tom Hudson
Reported 2012-03-20 11:57:09 PDT
In the review of https://bugs.webkit.org/show_bug.cgi?id=65063, Darin Adler pointed out that it's rarely useful to have a virtual function defined in the header. That pattern occurs all over BitmapImage.h and BitmapImageSingleFrameSkia.h; we should fix that by moving all virtual function definitions to cpp files (adding one for BitmapImageSingleFrameSkia). https://bugs.webkit.org/show_bug.cgi?id=66597 tracks larger-scale refactoring that should be done in this code.
Attachments
Patch (9.90 KB, patch)
2012-03-20 12:06 PDT, Tom Hudson 		no flags
DetailsFormatted DiffDiff
Patch (9.92 KB, patch)
2012-03-20 12:24 PDT, Tom Hudson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tom Hudson
Comment 1 2012-03-20 12:06:54 PDT
Created attachment 132870 [details] Patch
WebKit Review Bot
Comment 2 2012-03-20 12:10:36 PDT
Attachment 132870 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/BitmapImage.cpp:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tom Hudson
Comment 3 2012-03-20 12:24:55 PDT
Created attachment 132878 [details] Patch
James Robinson
Comment 4 2012-03-21 09:02:00 PDT
Comment on attachment 132878 [details] Patch OK
WebKit Review Bot
Comment 5 2012-03-21 10:44:07 PDT
Comment on attachment 132878 [details] Patch Clearing flags on attachment: 132878 Committed r111572: <http://trac.webkit.org/changeset/111572>
WebKit Review Bot
Comment 6 2012-03-21 10:44:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.