In the review of https://bugs.webkit.org/show_bug.cgi?id=65063, Darin Adler pointed out that it's rarely useful to have a virtual function defined in the header. That pattern occurs all over BitmapImage.h and BitmapImageSingleFrameSkia.h; we should fix that by moving all virtual function definitions to cpp files (adding one for BitmapImageSingleFrameSkia). https://bugs.webkit.org/show_bug.cgi?id=66597 tracks larger-scale refactoring that should be done in this code.
Created attachment 132870 [details] Patch
Attachment 132870 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/BitmapImage.cpp:534: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 132878 [details] Patch
Comment on attachment 132878 [details] Patch OK
Comment on attachment 132878 [details] Patch Clearing flags on attachment: 132878 Committed r111572: <http://trac.webkit.org/changeset/111572>
All reviewed patches have been landed. Closing bug.