Bug 81688 - Incremental cleanup of BitmapImage: inlined virtual functions
: Incremental cleanup of BitmapImage: inlined virtual functions
Product: WebKit
Classification: Unclassified
Component: Images
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Tom Hudson
Depends on:
  Show dependency treegraph
Reported: 2012-03-20 11:57 PDT by Tom Hudson
Modified: 2012-03-21 10:44 PDT (History)
4 users (show)

See Also:

Patch (9.90 KB, patch)
2012-03-20 12:06 PDT, Tom Hudson
no flags Details | Formatted Diff | Diff
Patch (9.92 KB, patch)
2012-03-20 12:24 PDT, Tom Hudson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Hudson 2012-03-20 11:57:09 PDT
In the review of https://bugs.webkit.org/show_bug.cgi?id=65063, Darin Adler pointed out that it's rarely useful to have a virtual function defined in the header. That pattern occurs all over BitmapImage.h and BitmapImageSingleFrameSkia.h; we should fix that by moving all virtual function definitions to cpp files (adding one for BitmapImageSingleFrameSkia).

https://bugs.webkit.org/show_bug.cgi?id=66597 tracks larger-scale refactoring that should be done in this code.
Comment 1 Tom Hudson 2012-03-20 12:06:54 PDT
Created attachment 132870 [details]
Comment 2 WebKit Review Bot 2012-03-20 12:10:36 PDT
Attachment 132870 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/BitmapImage.cpp:534:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tom Hudson 2012-03-20 12:24:55 PDT
Created attachment 132878 [details]
Comment 4 James Robinson 2012-03-21 09:02:00 PDT
Comment on attachment 132878 [details]

Comment 5 WebKit Review Bot 2012-03-21 10:44:07 PDT
Comment on attachment 132878 [details]

Clearing flags on attachment: 132878

Committed r111572: <http://trac.webkit.org/changeset/111572>
Comment 6 WebKit Review Bot 2012-03-21 10:44:11 PDT
All reviewed patches have been landed.  Closing bug.