Bug 81678

Summary: Make distributeExtraLogicalHeightToRows return the consumed logical height
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: TablesAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed fix 1. tony: review+, jchaffraix: commit-queue+

Julien Chaffraix
Reported 2012-03-20 10:18:04 PDT
Currently this function returns the remaining logical height. This is painful as the distribution algorithm is interested in consumed logical height to decrease the available logical height. This also means that there will be a need for some unneeded house-keeping. Let's change that.
Attachments
Proposed fix 1. (8.79 KB, patch)
2012-03-20 10:29 PDT, Julien Chaffraix 		tony: review+
jchaffraix: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-03-20 10:29:10 PDT
Created attachment 132847 [details] Proposed fix 1.
Tony Chang
Comment 2 2012-03-20 11:19:11 PDT
Comment on attachment 132847 [details] Proposed fix 1. View in context: https://bugs.webkit.org/attachment.cgi?id=132847&action=review > Source/WebCore/rendering/RenderTableSection.cpp:427 > -int RenderTableSection::distributeExtraLogicalHeightToPercentRows(int extraLogicalHeight, int totalPercent) > +void RenderTableSection::distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent) Nit: Maybe we should reverse the parameter order. I think in/out params normally come last. > Source/WebCore/rendering/RenderTableSection.cpp:454 > -int RenderTableSection::distributeExtraLogicalHeightToAutoRows(int extraLogicalHeight, unsigned autoRowsCount) > +void RenderTableSection::distributeExtraLogicalHeightToAutoRows(int& extraLogicalHeight, unsigned autoRowsCount) Ditto.
WebKit Review Bot
Comment 3 2012-03-20 11:30:21 PDT
Comment on attachment 132847 [details] Proposed fix 1. Attachment 132847 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12009301 New failing tests: fast/dom/error-to-string-stack-overflow.html
Julien Chaffraix
Comment 4 2012-03-20 12:55:37 PDT
Comment on attachment 132847 [details] Proposed fix 1. View in context: https://bugs.webkit.org/attachment.cgi?id=132847&action=review The test failing is unrelated to my change (I am hitting it locally without the patch). >> Source/WebCore/rendering/RenderTableSection.cpp:427 >> +void RenderTableSection::distributeExtraLogicalHeightToPercentRows(int& extraLogicalHeight, int totalPercent) > > Nit: Maybe we should reverse the parameter order. I think in/out params normally come last. I prefer it this way as it looks like |totalPercent| is an added parameter compared to distributeExtraLogicalHeightToRows.
Julien Chaffraix
Comment 5 2012-03-20 14:02:51 PDT
Committed r111435: <http://trac.webkit.org/changeset/111435>
Note You need to log in before you can comment on or make changes to this bug.