Bug 81666

Summary: (r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
Product: WebKit Reporter: Konrad Piascik <kpiascik>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Konrad Piascik 2012-03-20 08:19:52 PDT
(r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro
Comment 1 Konrad Piascik 2012-03-20 08:21:35 PDT
Created attachment 132828 [details]
Patch
Comment 2 Rob Buis 2012-03-20 08:23:49 PDT
Comment on attachment 132828 [details]
Patch

Better do it like this:

if (m_mousePressed && m_mouseDownMayStartSelect && 
#if ENABLE(DRAG_SUPPORT)
    !m_mouseDownMayStartDrag &&
#endif
     m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
Comment 3 Konrad Piascik 2012-03-20 08:31:38 PDT
Created attachment 132831 [details]
Patch
Comment 4 Rob Buis 2012-03-20 08:36:34 PDT
Comment on attachment 132831 [details]
Patch

Better :)
Comment 5 WebKit Review Bot 2012-03-20 09:18:14 PDT
Comment on attachment 132831 [details]
Patch

Clearing flags on attachment: 132831

Committed r111400: <http://trac.webkit.org/changeset/111400>
Comment 6 WebKit Review Bot 2012-03-20 09:18:18 PDT
All reviewed patches have been landed.  Closing bug.