Summary: | (r110063) m_mouseDownMayStartDrag is used without being behind the ENABLE(DRAG_SUPPORT) macro | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konrad Piascik <kpiascik> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Konrad Piascik
2012-03-20 08:19:52 PDT
Created attachment 132828 [details]
Patch
Comment on attachment 132828 [details]
Patch
Better do it like this:
if (m_mousePressed && m_mouseDownMayStartSelect &&
#if ENABLE(DRAG_SUPPORT)
!m_mouseDownMayStartDrag &&
#endif
m_frame->selection()->isCaretOrRange() && !m_capturingMouseEventsNode)
Created attachment 132831 [details]
Patch
Comment on attachment 132831 [details]
Patch
Better :)
Comment on attachment 132831 [details] Patch Clearing flags on attachment: 132831 Committed r111400: <http://trac.webkit.org/changeset/111400> All reviewed patches have been landed. Closing bug. |