Bug 81597

Summary: [Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Joshua Bell
Reported 2012-03-19 17:05:47 PDT
[Chromium] IndexedDB: Expose necessary IDB exception codes through WebKit API
Attachments
Patch (5.64 KB, patch)
2012-03-19 17:08 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.53 KB, patch)
2012-03-20 12:08 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-03-19 17:08:50 PDT
Created attachment 132727 [details] Patch
Joshua Bell
Comment 2 2012-03-19 17:09:30 PDT
fishd@ can you review?
WebKit Review Bot
Comment 3 2012-03-19 17:11:38 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 4 2012-03-20 11:25:22 PDT
Comment on attachment 132727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132727&action=review > Source/WebKit/chromium/public/WebIDBDatabaseException.h:34 > +#include "platform/WebCommon.h" nit: looks like you can do away with this include > Source/WebKit/chromium/public/WebIDBDatabaseException.h:38 > +// These values must match WebCore::IDBDatabaseException values we usually don't leave comments like these in the header files. if someone renames IDBDatabaseException, they are probably unlikely to search for, find and then revise this comment.
Joshua Bell
Comment 5 2012-03-20 12:08:06 PDT
Created attachment 132872 [details] Patch for landing
Joshua Bell
Comment 6 2012-03-20 12:13:35 PDT
(In reply to comment #4) > (From update of attachment 132727 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132727&action=review > > > Source/WebKit/chromium/public/WebIDBDatabaseException.h:34 > > +#include "platform/WebCommon.h" > > nit: looks like you can do away with this include Done... > > Source/WebKit/chromium/public/WebIDBDatabaseException.h:38 > > +// These values must match WebCore::IDBDatabaseException values > > we usually don't leave comments like these in the header files. if someone renames > IDBDatabaseException, they are probably unlikely to search for, find and then revise > this comment. ... and done.
WebKit Review Bot
Comment 7 2012-03-20 13:16:04 PDT
Comment on attachment 132872 [details] Patch for landing Rejecting attachment 132872 [details] from commit-queue. New failing tests: fast/dom/error-to-string-stack-overflow.html Full output: http://queues.webkit.org/results/12047004
Joshua Bell
Comment 8 2012-03-20 14:16:11 PDT
Comment on attachment 132872 [details] Patch for landing Failure was unrelated; retrying cq
WebKit Review Bot
Comment 9 2012-03-20 16:31:49 PDT
Comment on attachment 132872 [details] Patch for landing Rejecting attachment 132872 [details] from commit-queue. New failing tests: fast/dom/error-to-string-stack-overflow.html Full output: http://queues.webkit.org/results/12035087
Joshua Bell
Comment 10 2012-03-21 08:56:01 PDT
Comment on attachment 132872 [details] Patch for landing Trying again, hoping the fast/dom/error-to-string-stack-overflow.html test issue has been cleared up.
WebKit Review Bot
Comment 11 2012-03-21 09:36:49 PDT
Comment on attachment 132872 [details] Patch for landing Clearing flags on attachment: 132872 Committed r111552: <http://trac.webkit.org/changeset/111552>
WebKit Review Bot
Comment 12 2012-03-21 09:36:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.