Bug 81595

Summary: webkitpy: clean up some port._filesystem references to not reference private members
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71380    
Attachments:
Description Flags
Patch
none
fix nit in write_image_diff_files() as well eric: review+

Description Dirk Pranke 2012-03-19 16:54:54 PDT 
webkitpy: clean up some port._filesystem references to not reference private members
Comment 1 Dirk Pranke 2012-03-19 16:55:31 PDT 
Created attachment 132722 [details]
Patch
Comment 2 Dirk Pranke 2012-03-19 17:01:23 PDT 
Created attachment 132725 [details]
fix nit in write_image_diff_files() as well
Comment 3 Eric Seidel (no email) 2012-03-19 17:16:58 PDT 
Comment on attachment 132725 [details]
fix nit in write_image_diff_files() as well

View in context: https://bugs.webkit.org/attachment.cgi?id=132725&action=review

OK.

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:71
> -                if port.host.filesystem.exists(expected_filename):
> +                if self._filesystem.exists(expected_filename):

In general getting away from using "port" for these sorts of things seems good.  The goal being to make "port" less of the hub/god object.
Comment 4 Dirk Pranke 2012-03-19 18:26:03 PDT 
Committed r111289: <http://trac.webkit.org/changeset/111289>