Bug 81582

Summary: [GTK] libWebCore.la has become too big for make
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Gustavo Noronha (kov) 2012-03-19 16:08:58 PDT
[GTK] libWebCore.la has become too big for make
Comment 1 Gustavo Noronha (kov) 2012-03-19 16:13:02 PDT
Created attachment 132701 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-03-19 16:19:52 PDT
For reference: http://webkit-commit-queue.appspot.com/results/11986485
Comment 3 Gustavo Noronha (kov) 2012-03-19 16:32:46 PDT
Comment on attachment 132701 [details]
Patch

Attachment 132701 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11984850
Comment 4 Gustavo Noronha (kov) 2012-03-19 16:52:50 PDT
Created attachment 132718 [details]
Patch
Comment 5 Gustavo Noronha (kov) 2012-03-19 19:08:19 PDT
Created attachment 132743 [details]
Patch
Comment 6 Gustavo Noronha (kov) 2012-03-19 20:22:47 PDT
Comment on attachment 132743 [details]
Patch

Clearing flags on attachment: 132743

Committed r111340: <http://trac.webkit.org/changeset/111340>
Comment 7 Gustavo Noronha (kov) 2012-03-19 20:22:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Martin Robinson 2012-03-24 08:52:01 PDT
Was this the "argument list too long" error?
Comment 9 Gustavo Noronha (kov) 2012-03-27 11:23:19 PDT
Yes, it was. This was a quick fix to get the bots going, but I'm afraid we'll have to strive in keeping the argument list small for people building tarballs, in any case. Hopefully the recent trend towards breaking up WebCore continues.
Comment 10 Martin Robinson 2012-03-27 11:26:47 PDT
(In reply to comment #9)
> Yes, it was. This was a quick fix to get the bots going, but I'm afraid we'll have to strive in keeping the argument list small for people building tarballs, in any case. Hopefully the recent trend towards breaking up WebCore continues.

The main issue is that it really slows down the linking phase.
Comment 11 Gustavo Noronha (kov) 2012-03-27 11:32:13 PDT
I don't see many ways out. Perhaps have different intermediate libraries for bot builds and regular builds somehow? That may bring complexity up to untractable levels =(