Bug 81582

Summary: [GTK] libWebCore.la has become too big for make
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gustavo Noronha (kov)
Reported 2012-03-19 16:08:58 PDT
[GTK] libWebCore.la has become too big for make
Attachments
Patch (4.73 KB, patch)
2012-03-19 16:13 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Patch (5.26 KB, patch)
2012-03-19 16:52 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Patch (7.43 KB, patch)
2012-03-19 19:08 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2012-03-19 16:13:02 PDT
Created attachment 132701 [details] Patch
Gustavo Noronha (kov)
Comment 2 2012-03-19 16:19:52 PDT
For reference: http://webkit-commit-queue.appspot.com/results/11986485
Gustavo Noronha (kov)
Comment 3 2012-03-19 16:32:46 PDT
Comment on attachment 132701 [details] Patch Attachment 132701 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11984850
Gustavo Noronha (kov)
Comment 4 2012-03-19 16:52:50 PDT
Created attachment 132718 [details] Patch
Gustavo Noronha (kov)
Comment 5 2012-03-19 19:08:19 PDT
Created attachment 132743 [details] Patch
Gustavo Noronha (kov)
Comment 6 2012-03-19 20:22:47 PDT
Comment on attachment 132743 [details] Patch Clearing flags on attachment: 132743 Committed r111340: <http://trac.webkit.org/changeset/111340>
Gustavo Noronha (kov)
Comment 7 2012-03-19 20:22:53 PDT
All reviewed patches have been landed. Closing bug.
Martin Robinson
Comment 8 2012-03-24 08:52:01 PDT
Was this the "argument list too long" error?
Gustavo Noronha (kov)
Comment 9 2012-03-27 11:23:19 PDT
Yes, it was. This was a quick fix to get the bots going, but I'm afraid we'll have to strive in keeping the argument list small for people building tarballs, in any case. Hopefully the recent trend towards breaking up WebCore continues.
Martin Robinson
Comment 10 2012-03-27 11:26:47 PDT
(In reply to comment #9) > Yes, it was. This was a quick fix to get the bots going, but I'm afraid we'll have to strive in keeping the argument list small for people building tarballs, in any case. Hopefully the recent trend towards breaking up WebCore continues. The main issue is that it really slows down the linking phase.
Gustavo Noronha (kov)
Comment 11 2012-03-27 11:32:13 PDT
I don't see many ways out. Perhaps have different intermediate libraries for bot builds and regular builds somehow? That may bring complexity up to untractable levels =(
Note You need to log in before you can comment on or make changes to this bug.