| Summary: | [New Multicolumn] Stub out new classes to represent the region boxes for columns. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dave Hyatt
2012-03-19 13:37:21 PDT
Created attachment 132653 [details]
Patch
Attachment 132653 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderRegionSet.h:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 132653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132653&action=review > Source/WebCore/rendering/RenderMultiColumnSet.h:35 > +// object, we significantly reduce the # of unique RenderObjects required to represent columns. Spell out “number”? > Source/WebCore/rendering/RenderRegionSet.h:40 > +// By combining runs of same-size columns or pages into a single object, we significantly reduce the # of unique RenderObjects Ditto. |