Summary: | Move the extra logical height distribution into RenderTable as a new step in our layout algorithm | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> | ||||||
Component: | Tables | Assignee: | Julien Chaffraix <jchaffraix> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hyatt, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Julien Chaffraix
2012-03-19 13:13:32 PDT
Created attachment 132654 [details]
Proposed refactoring 1.
Comment on attachment 132654 [details]
Proposed refactoring 1.
Seems reasonable.
Comment on attachment 132654 [details] Proposed refactoring 1. Attachment 132654 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11990028 Comment on attachment 132654 [details] Proposed refactoring 1. View in context: https://bugs.webkit.org/attachment.cgi?id=132654&action=review > Source/WebCore/rendering/RenderTable.cpp:307 > + for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) { Windows complains rightly here that we will never reach some of the statements. I will fix that and re-upload to see if it helps with the Win EWS. Created attachment 132703 [details]
For win EWS testing.
Comment on attachment 132703 [details]
For win EWS testing.
It did the trick.
Comment on attachment 132703 [details] For win EWS testing. Clearing flags on attachment: 132703 Committed r111353: <http://trac.webkit.org/changeset/111353> All reviewed patches have been landed. Closing bug. |