Bug 81548

Summary: Move the extra logical height distribution into RenderTable as a new step in our layout algorithm
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: TablesAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed refactoring 1.
none
For win EWS testing. none

Julien Chaffraix
Reported 2012-03-19 13:13:32 PDT
This refactoring is needed to be able to implement a better distribution algorithm that would properly handle several sections. Patch forthcoming.
Attachments
Proposed refactoring 1. (7.45 KB, patch)
2012-03-19 13:40 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
For win EWS testing. (7.41 KB, patch)
2012-03-19 16:19 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2012-03-19 13:40:55 PDT
Created attachment 132654 [details] Proposed refactoring 1.
Tony Chang
Comment 2 2012-03-19 14:16:10 PDT
Comment on attachment 132654 [details] Proposed refactoring 1. Seems reasonable.
Build Bot
Comment 3 2012-03-19 15:29:13 PDT
Comment on attachment 132654 [details] Proposed refactoring 1. Attachment 132654 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11990028
Julien Chaffraix
Comment 4 2012-03-19 16:03:46 PDT
Comment on attachment 132654 [details] Proposed refactoring 1. View in context: https://bugs.webkit.org/attachment.cgi?id=132654&action=review > Source/WebCore/rendering/RenderTable.cpp:307 > + for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) { Windows complains rightly here that we will never reach some of the statements. I will fix that and re-upload to see if it helps with the Win EWS.
Julien Chaffraix
Comment 5 2012-03-19 16:19:58 PDT
Created attachment 132703 [details] For win EWS testing.
Julien Chaffraix
Comment 6 2012-03-19 20:58:15 PDT
Comment on attachment 132703 [details] For win EWS testing. It did the trick.
WebKit Review Bot
Comment 7 2012-03-19 21:53:34 PDT
Comment on attachment 132703 [details] For win EWS testing. Clearing flags on attachment: 132703 Committed r111353: <http://trac.webkit.org/changeset/111353>
WebKit Review Bot
Comment 8 2012-03-19 21:53:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.