Summary: | [BlackBerry] Add new layout test for text match marker | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Chen <andchen> | ||||||||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, mifenton, rwlbuis, tonikitoo, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Andy Chen
2012-03-19 11:32:00 PDT
Created attachment 132618 [details]
patch
Comment on attachment 132618 [details]
patch
LGTM.
Comment on attachment 132618 [details] patch Rejecting attachment 132618 [details] from commit-queue. New failing tests: platform/blackberry/editing/text-iterator/findString-markers.html Full output: http://queues.webkit.org/results/11989249 (In reply to comment #3) > (From update of attachment 132618 [details]) > Rejecting attachment 132618 [details] from commit-queue. > > New failing tests: > platform/blackberry/editing/text-iterator/findString-markers.html > Full output: http://queues.webkit.org/results/11989249 The output says nothing about my test case. Comment on attachment 132618 [details] patch Attachment 132618 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11981860 New failing tests: platform/blackberry/editing/text-iterator/findString-markers.html (In reply to comment #5) > (From update of attachment 132618 [details]) > Attachment 132618 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11981860 > > New failing tests: > platform/blackberry/editing/text-iterator/findString-markers.html It is a test for blackberry port only, cr-linux should not even test it. Created attachment 132640 [details]
updated text-expectations for cr
Attachment 132640 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium/test_expectations.txt:575: Missing expectations WONTFIX SKIP : platform/blackberry/editing/text-iterator/findString-markers.html [test/expectations] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 132646 [details]
updated text-expectations for cr
Attachment 132646 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/chromium/test_expectations.txt:575: Missing expectations WONTFIX SKIP : platform/blackberry/editing/text-iterator/findString-markers.html PASS TIMEOUT FAIL [test/expectations] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 132647 [details]
updated text-expectations for cr
Comment on attachment 132647 [details]
updated text-expectations for cr
Seems no errors now, lets retry.
Comment on attachment 132647 [details] updated text-expectations for cr Clearing flags on attachment: 132647 Committed r111256: <http://trac.webkit.org/changeset/111256> All reviewed patches have been landed. Closing bug. |