Bug 81530

Summary: platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cfleizach, jberlin, webkit-bug-importer
Priority: P2 Keywords: InRadar, LayoutTestFailure, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r111198%20(5036)/platform/mac/accessibility/selected-rows-table-pretty-diff.html
Attachments:
Description Flags
patch jberlin: review+

Description Jessie Berlin 2012-03-19 11:31:48 PDT 
http://build.webkit.org/results/Lion%20Intel%20Debug%20(WebKit2%20Tests)/r111198%20(5036)/platform/mac/accessibility/selected-rows-table-pretty-diff.html

--- /Volumes/Data/slave/lion-intel-debug-tests-wk2/build/layout-test-results/platform/mac/accessibility/selected-rows-table-expected.txt
+++ /Volumes/Data/slave/lion-intel-debug-tests-wk2/build/layout-test-results/platform/mac/accessibility/selected-rows-table-actual.txt
@@ -11,8 +11,8 @@
 

 PASS addedNotification is true
-PASS axTree.selectedRowAtIndex(0).isEqual(axTree.rowAtIndex(0)) is true
-PASS axTree.selectedRowAtIndex(1).isEqual(axTree.rowAtIndex(2)) is true
+FAIL axTree.selectedRowAtIndex(0).isEqual(axTree.rowAtIndex(0)) should be true. Threw exception TypeError: 'undefined' is not a function (evaluating 'axTree.rowAtIndex(0)')
+FAIL axTree.selectedRowAtIndex(1).isEqual(axTree.rowAtIndex(2)) should be true. Threw exception TypeError: 'undefined' is not a function (evaluating 'axTree.rowAtIndex(2)')
 PASS successfullyParsed is true
 
 TEST COMPLETE

Unfortunately, due to the state of our tests, I don't know when this started.
Comment 1 Radar WebKit Bug Importer 2012-03-19 11:33:24 PDT 
<rdar://problem/11074696>
Comment 2 Jessie Berlin 2012-03-19 11:39:07 PDT 
Added expected failing results for mac-wk2 in http://trac.webkit.org/changeset/111210
Comment 3 chris fleizach 2012-03-19 11:50:13 PDT 
might be that i forgot to add this method to WK test runner
Comment 4 Jessie Berlin 2012-03-19 11:52:09 PDT 
(In reply to comment #3)
> might be that i forgot to add this method to WK test runner

Yes, "rowAtIndex" appears to be missing from AccessibilityUIElement.h in WebKitTestRunner's project.
Comment 5 chris fleizach 2012-03-19 13:18:11 PDT 
Created attachment 132642 [details]
patch
Comment 6 Jessie Berlin 2012-03-19 13:25:57 PDT 
Comment on attachment 132642 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132642&action=review

r=me!

> Tools/ChangeLog:8
> +        At rowAtIndex to WebKitTestRunner

Typo: "At" instead of "Add".
Nit pick: Please end with a period.

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:341
> +

Nit pick: please remove this extra line.
Comment 7 chris fleizach 2012-03-19 13:30:09 PDT 
http://trac.webkit.org/changeset/111233