Bug 81512

Summary: [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch
none
Patch
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-03-19 08:46:44 PDT
Add markerTextForListItem() to EFL's LayoutTestController and enable related tests.
Attachments
Patch (6.02 KB, patch)
2012-03-19 09:14 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
patch (6.01 KB, patch)
2012-03-19 09:24 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (6.01 KB, patch)
2012-03-20 04:28 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (6.20 KB, patch)
2012-03-22 09:58 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-03-19 09:14:15 PDT
Created attachment 132595 [details] Patch Implement markerTextForListItem and enable tests.
WebKit Review Bot
Comment 2 2012-03-19 09:19:13 PDT
Attachment 132595 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 Source/WebKit/efl/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:84: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sudarsana Nagineni (babu)
Comment 3 2012-03-19 09:24:57 PDT
Created attachment 132596 [details] patch fix style check errors
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-03-19 09:31:51 PDT
Comment on attachment 132596 [details] patch Thanks for the patch. It looks OK, but I'd rather return a String in DRTSupportEfl::markerTextForListItem() and then do the String->CString->char* conversion in LTC::markerTextForListItem() instead, as in general we work and pass String's around.
Sudarsana Nagineni (babu)
Comment 5 2012-03-20 04:28:31 PDT
Created attachment 132798 [details] Patch Fix review comment #4
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-03-20 06:19:01 PDT
Comment on attachment 132798 [details] Patch Looks good, thank you.
Sudarsana Nagineni (babu)
Comment 7 2012-03-22 09:58:35 PDT
Created attachment 133284 [details] Patch rebased
WebKit Review Bot
Comment 8 2012-03-22 13:52:04 PDT
Comment on attachment 133284 [details] Patch Clearing flags on attachment: 133284 Committed r111756: <http://trac.webkit.org/changeset/111756>
WebKit Review Bot
Comment 9 2012-03-22 13:52:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.