Bug 81498
Summary: | [Qt] Buildfix after r111076 on x86 | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Blocker | CC: | ossy, pandras, tony |
Priority: | P1 | Keywords: | Qt, QtTriaged |
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 69521 |
Csaba Osztrogonác
http://trac.webkit.org/changeset/111076 broke the 32 bit QtWebKit build.
(Qt Linux Release, Qt Linux Release minimal, x86-32 Linux Qt Release - Qt5-WebKit1,
x86-32 Linux Qt Release WebKit2, x86-32 Linux Qt Release NRWT bots)
Unfortunately it was hidden build break, because http://trac.webkit.org/changeset/111075
broke the build previously and only http://trac.webkit.org/changeset/111106 fixed it.
It seems it might be a gcc bug and we should make a workaround somehow.
(But it is strange that build works fine with same gcc version on 64 bit.)
build log:
===========
cc1plus: warnings being treated as errors
In file included from ../../../../Source/JavaScriptCore/wtf/HashMap.h:25,
from ../../../../Source/WebCore/platform/network/HTTPHeaderMap.h:32,
from ../../../../Source/WebCore/platform/network/ResourceResponseBase.h:31,
from ../../../../Source/WebCore/platform/network/qt/ResourceResponse.h:30,
from ../../../../Source/WebCore/platform/network/AuthenticationChallengeBase.h:31,
from ../../../../Source/WebCore/platform/network/qt/AuthenticationChallenge.h:29,
from ../../../../Source/WebCore/platform/network/ResourceHandle.h:30,
from ../../../../Source/WebCore/loader/ResourceLoaderOptions.h:35,
from ../../../../Source/WebCore/loader/cache/CachedResource.h:31,
from ../../../../Source/WebCore/loader/cache/CachedImage.h:27,
from ../../../../Source/WebCore/rendering/RenderObject.h:30,
from ../../../../Source/WebCore/rendering/RenderBoxModelObject.h:28,
from ../../../../Source/WebCore/rendering/RenderBox.h:27,
from ../../../../Source/WebCore/rendering/RenderBlock.h:30,
from ../../../../Source/WebCore/rendering/RenderTable.h:31,
from ../../../../Source/WebCore/rendering/RenderTableSection.h:29,
from ../../../../Source/WebCore/rendering/RenderTableSection.cpp:28:
../../../../Source/JavaScriptCore/wtf/HashTraits.h: In member function 'void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::rehash(int) [with Key = std::pair<const WebCore::RenderTableCell*, int>, Value = std::pair<std::pair<const WebCore::RenderTableCell*, int>, WebCore::CollapsedBorderValue>, Extractor = WTF::PairFirstExtractor<std::pair<std::pair<const WebCore::RenderTableCell*, int>, WebCore::CollapsedBorderValue> >, HashFunctions = WTF::PairHash<const WebCore::RenderTableCell*, int>, Traits = WTF::PairHashTraits<WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >, WTF::HashTraits<WebCore::CollapsedBorderValue> >, KeyTraits = WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >]':
../../../../Source/JavaScriptCore/wtf/HashTraits.h:153: error: '__y' may be used uninitialized in this function
../../../../Source/JavaScriptCore/wtf/HashTraits.h:153: note: '__y' was declared here
In file included from ../../../../Source/WebCore/platform/network/HTTPHeaderMap.h:32,
from ../../../../Source/WebCore/platform/network/ResourceResponseBase.h:31,
from ../../../../Source/WebCore/platform/network/qt/ResourceResponse.h:30,
from ../../../../Source/WebCore/platform/network/AuthenticationChallengeBase.h:31,
from ../../../../Source/WebCore/platform/network/qt/AuthenticationChallenge.h:29,
from ../../../../Source/WebCore/platform/network/ResourceHandle.h:30,
from ../../../../Source/WebCore/loader/ResourceLoaderOptions.h:35,
from ../../../../Source/WebCore/loader/cache/CachedResource.h:31,
from ../../../../Source/WebCore/loader/cache/CachedImage.h:27,
from ../../../../Source/WebCore/rendering/RenderObject.h:30,
from ../../../../Source/WebCore/rendering/RenderBoxModelObject.h:28,
from ../../../../Source/WebCore/rendering/RenderBox.h:27,
from ../../../../Source/WebCore/rendering/RenderBlock.h:30,
from ../../../../Source/WebCore/rendering/RenderTable.h:31,
from ../../../../Source/WebCore/rendering/RenderTableSection.h:29,
from ../../../../Source/WebCore/rendering/RenderTableSection.cpp:28:
../../../../Source/WebCore/rendering/RenderTableSection.cpp: In member function 'std::pair<typename WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::iterator, bool> WTF::HashMap<KeyArg, MappedArg, HashArg, KeyTraitsArg, MappedTraitsArg>::set(const typename KeyTraitsArg::TraitType&, typename MappedTraitsArg::PassInType) [with KeyArg = std::pair<const WebCore::RenderTableCell*, int>, MappedArg = WebCore::CollapsedBorderValue, HashArg = WTF::PairHash<const WebCore::RenderTableCell*, int>, KeyTraitsArg = WTF::HashTraits<std::pair<const WebCore::RenderTableCell*, int> >, MappedTraitsArg = WTF::HashTraits<WebCore::CollapsedBorderValue>]':
../../../../Source/WebCore/rendering/RenderTableSection.cpp:1424: error: '__y' may be used uninitialized in this function
../../../../Source/JavaScriptCore/wtf/HashTraits.h:153: note: '__y' was declared here
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
I disabled -Werror on x86 until proper fix to unblock our buildbots and EWS bots - http://trac.webkit.org/changeset/111158
Tony Chang
*** This bug has been marked as a duplicate of bug 81502 ***
Tony Chang
It looks like http://trac.webkit.org/changeset/111171 should fix the bug, so you may want to re-enable werror.
Csaba Osztrogonác
(In reply to comment #3)
> It looks like http://trac.webkit.org/changeset/111171 should fix the bug, so you may want to re-enable werror.
Thanks, it fixed the bug. I reenabled werror - http://trac.webkit.org/changeset/111375.