Bug 81474

Summary: Fix compile when FULLSCREEN_API is not enabled on Mac
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: psolanki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch adachan: review+

Description Pratik Solanki 2012-03-18 11:47:55 PDT 
Build fails if FULLSCREEN_API is not enabled on mac. We should guard the code inside ENABLE(FULLSCREEN_API).
Comment 1 Pratik Solanki 2012-03-18 11:50:05 PDT 
Created attachment 132500 [details]
Patch
Comment 2 Ada Chan 2012-03-18 11:59:24 PDT 
Comment on attachment 132500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132500&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:29
> +#if ENABLE(FULLSCREEN_API)

Can '#import "WebCoreFullScreenWindow.h"' be placed inside the #if ENABLE(FULLSCREEN_API) block?
Comment 3 Pratik Solanki 2012-03-18 12:10:37 PDT 
Comment on attachment 132500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132500&action=review

>> Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:29
>> +#if ENABLE(FULLSCREEN_API)
> 
> Can '#import "WebCoreFullScreenWindow.h"' be placed inside the #if ENABLE(FULLSCREEN_API) block?

Yeah, it probably should. I will make that change before committing. Thanks for the review.
Comment 4 Pratik Solanki 2012-03-18 12:17:34 PDT 
Committed r111135: <http://trac.webkit.org/changeset/111135>