Bug 81474 - Fix compile when FULLSCREEN_API is not enabled on Mac
Summary: Fix compile when FULLSCREEN_API is not enabled on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-18 11:47 PDT by Pratik Solanki
Modified: 2012-03-18 12:17 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2012-03-18 11:50 PDT, Pratik Solanki 		adachan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2012-03-18 11:47:55 PDT 
Build fails if FULLSCREEN_API is not enabled on mac. We should guard the code inside ENABLE(FULLSCREEN_API).
Comment 1 Pratik Solanki 2012-03-18 11:50:05 PDT 
Created attachment 132500 [details]
Patch
Comment 2 Ada Chan 2012-03-18 11:59:24 PDT 
Comment on attachment 132500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132500&action=review

> Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:29
> +#if ENABLE(FULLSCREEN_API)

Can '#import "WebCoreFullScreenWindow.h"' be placed inside the #if ENABLE(FULLSCREEN_API) block?
Comment 3 Pratik Solanki 2012-03-18 12:10:37 PDT 
Comment on attachment 132500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132500&action=review

>> Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm:29
>> +#if ENABLE(FULLSCREEN_API)
> 
> Can '#import "WebCoreFullScreenWindow.h"' be placed inside the #if ENABLE(FULLSCREEN_API) block?

Yeah, it probably should. I will make that change before committing. Thanks for the review.
Comment 4 Pratik Solanki 2012-03-18 12:17:34 PDT 
Committed r111135: <http://trac.webkit.org/changeset/111135>