Bug 81465

Summary:

VCSUtils.pm: Prefer "gpatch" over "patch" when it is available.

Product:

WebKit

Reporter:

Raphael Kubo da Costa (:rakuco) <rakuco>

Component:

Tools / Tests

Assignee:

Raphael Kubo da Costa (:rakuco) <rakuco>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, aroben, eric, haraken, mrobinson, xan.lopez

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	abarth: review-

Raphael Kubo da Costa (:rakuco)

Reported 2012-03-17 22:09:05 PDT

VCUtils.pm: Prefer "gpatch" over "patch" when it is available.

Attachments
Patch (5.56 KB, patch) 2012-03-17 22:11 PDT, Raphael Kubo da Costa (:rakuco)	no flags	Details Formatted Diff Diff
Patch (5.35 KB, patch) 2012-03-17 22:21 PDT, Raphael Kubo da Costa (:rakuco)	no flags	Details Formatted Diff Diff
Patch (5.39 KB, patch) 2012-03-17 22:23 PDT, Raphael Kubo da Costa (:rakuco)	abarth: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Raphael Kubo da Costa (:rakuco)

Comment 1 2012-03-17 22:11:23 PDT

Created attachment 132480 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2012-03-17 22:21:02 PDT

Created attachment 132481 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 3 2012-03-17 22:23:15 PDT

Created attachment 132482 [details] Patch

Adam Barth

Comment 4 2012-03-19 00:31:36 PDT

Comment on attachment 132482 [details] Patch Before we start landing patches like this, we should have a more general discussion on webkit-dev about whether we're going to support FreeBSD and which ports want this support.

Raphael Kubo da Costa (:rakuco)

Comment 5 2012-05-03 18:50:27 PDT

I think it makes sense to close this. There is no standardization around "alternative names" for the patch binary, so "gpatch" can be considered an arbitrary name which works on a certain OS. Symlinking gpatch to patch in a directory and prepending it to $PATH has the same effect.

Note You need to log in before you can comment on or make changes to this bug.