Bug 81445

Summary:

Simplify SmallStrings

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

JavaScriptCore

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren

Priority:

Keywords:

EasyFix

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	barraclough: review+

Description Benjamin Poulain 2012-03-16 23:19:27 PDT

You might wonder why SmallStrings has a public clear() and count(), so do I.

Comment 1 Benjamin Poulain 2012-03-16 23:26:13 PDT

Created attachment 132449 [details]
Patch

Comment 2 Benjamin Poulain 2012-03-19 19:11:42 PDT

Committed r111306: <http://trac.webkit.org/changeset/111306>

Comment 3 Darin Adler 2012-03-23 09:04:40 PDT

Comment on attachment 132449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132449&action=review

> Source/JavaScriptCore/runtime/SmallStrings.cpp:74
> +    m_emptyString = 0;

Would be even better to use an initializer for this instead of assignment in the body of the function.

Comment 4 Benjamin Poulain 2012-03-23 11:51:01 PDT

> > Source/JavaScriptCore/runtime/SmallStrings.cpp:74
> > +    m_emptyString = 0;
> 
> Would be even better to use an initializer for this instead of assignment in the body of the function.

This was the first of a pair of patch. The second actually did that, so no worries :)