Bug 81440

Summary:

extract logic of idb tests

Product:

WebKit

Reporter:

David Grogan <dgrogan>

Component:

New Bugs

Assignee:

David Grogan <dgrogan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jsbell, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none

David Grogan

Reported 2012-03-16 18:31:23 PDT

extract logic of idb tests

Attachments
Patch (683.49 KB, patch) 2012-03-16 18:32 PDT, David Grogan	no flags	Details Formatted Diff Diff
Patch (672.32 KB, patch) 2012-03-22 17:35 PDT, David Grogan	no flags	Details Formatted Diff Diff
Patch (1023.14 KB, patch) 2012-03-23 13:31 PDT, David Grogan	no flags	Details Formatted Diff Diff
Patch (1023.79 KB, patch) 2012-03-23 13:52 PDT, David Grogan	no flags	Details Formatted Diff Diff
Patch (991.02 KB, patch) 2012-03-23 15:48 PDT, David Grogan	no flags	Details Formatted Diff Diff
Patch for landing (939.83 KB, patch) 2012-03-26 15:37 PDT, David Grogan	no flags	Details Formatted Diff Diff
Patch for landing (939.83 KB, patch) 2012-03-26 16:49 PDT, David Grogan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

David Grogan

Comment 1 2012-03-16 18:32:14 PDT

Created attachment 132434 [details] Patch

David Grogan

Comment 2 2012-03-16 18:36:01 PDT

not ready for review yet, just FYI

David Grogan

Comment 3 2012-03-22 17:35:35 PDT

Created attachment 133399 [details] Patch

David Grogan

Comment 4 2012-03-23 13:31:07 PDT

Created attachment 133549 [details] Patch

David Grogan

Comment 5 2012-03-23 13:52:39 PDT

Created attachment 133551 [details] Patch

David Grogan

Comment 6 2012-03-23 13:55:03 PDT

Comment on attachment 133551 [details] Patch Josh, this is ready for a look.

Joshua Bell

Comment 7 2012-03-23 14:47:26 PDT

Comment on attachment 133551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133551&action=review > LayoutTests/ChangeLog:14 > + The first three simulate mouse events and the last isn't really a test. structured-clone.html uses mouse events too (to create File/FileList objects, although those tests are currently disabled). Should it be skipped too? That test also uses a few more things like ImageData that workers won't be able to create. We may want to split that test up or make it validate both window and worker cases, passing the cloned values to the worker. (values-odd-types.html does similar work, but is probably a redundant subset now) > LayoutTests/storage/indexeddb/createObjectStore-name-argument-required.html:-1 > -<!DOCTYPE html> Just removing the DOCTYPE preamble for consistency? In IE this is used to trigger "standards mode", I don't know if WebKit actually does anything with it. It shouldn't matter either way for the test. It's strictly required by the HTML5 spec, though - http://dev.w3.org/html5/spec/single-page.html#syntax-doctype > LayoutTests/storage/indexeddb/list-ordering.html:-7 > -<input type="file" id="fileInput" multiple></input> Oops, thanks for deleting this.

Joshua Bell

Comment 8 2012-03-23 14:47:43 PDT

... and otherwise lgtm

David Grogan

Comment 9 2012-03-23 15:35:23 PDT

(In reply to comment #7) > (From update of attachment 133551 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=133551&action=review > > > LayoutTests/ChangeLog:14 > > + The first three simulate mouse events and the last isn't really a test. > > structured-clone.html uses mouse events too (to create File/FileList objects, although those tests are currently disabled). Should it be skipped too? > > That test also uses a few more things like ImageData that workers won't be able to create. We may want to split that test up or make it validate both window and worker cases, passing the cloned values to the worker. (values-odd-types.html does similar work, but is probably a redundant subset now) Structured cloning on workers seems ripe for corner cases so I want to do one of your suggestions, or something intelligent, but will skip it for now. > > LayoutTests/storage/indexeddb/createObjectStore-name-argument-required.html:-1 > > -<!DOCTYPE html> > > Just removing the DOCTYPE preamble for consistency? Just for consistency. All the html files were generated from a single template. In IE this is used to trigger "standards mode", I don't know if WebKit actually does anything with it. It shouldn't matter either way for the test. It's strictly required by the HTML5 spec, though - http://dev.w3.org/html5/spec/single-page.html#syntax-doctype > > > LayoutTests/storage/indexeddb/list-ordering.html:-7 > > -<input type="file" id="fileInput" multiple></input> > > Oops, thanks for deleting this.

David Grogan

Comment 10 2012-03-23 15:48:12 PDT

Created attachment 133576 [details] Patch

David Grogan

Comment 11 2012-03-23 17:55:20 PDT

Tony, could you review this? I'm not sure why win-ews can't apply the patch. win_layout_rel applied it without problems. http://build.chromium.org/p/tryserver.chromium/builders/win_layout_rel/builds/152/steps/update/logs/stdio

Tony Chang

Comment 12 2012-03-26 09:24:04 PDT

Comment on attachment 133576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133576&action=review rs=me > LayoutTests/ChangeLog:29 > + * storage/indexeddb/constants.html: > + * storage/indexeddb/create-and-remove-object-store.html: > + * storage/indexeddb/create-object-store-options.html: > + * storage/indexeddb/createObjectStore-name-argument-required.html: > + * storage/indexeddb/createObjectStore-null-name.html: > + * storage/indexeddb/cursor-continue.html: > + * storage/indexeddb/cursor-delete.html: It's OK to trim this. You could just list the important files (e.g., the two -expected.txt files where line numbers changed).

David Grogan

Comment 13 2012-03-26 15:37:55 PDT

Created attachment 133907 [details] Patch for landing

WebKit Review Bot

Comment 14 2012-03-26 16:41:21 PDT

Attachment 133907 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/stor..." exit_code: 1 LayoutTests/ChangeLog:26: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 245 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 15 2012-03-26 16:43:39 PDT

Comment on attachment 133907 [details] Patch for landing Rejecting attachment 133907 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12148089

David Grogan

Comment 16 2012-03-26 16:49:24 PDT

Created attachment 133931 [details] Patch for landing

WebKit Review Bot

Comment 17 2012-03-26 20:51:27 PDT

Comment on attachment 133931 [details] Patch for landing Clearing flags on attachment: 133931 Committed r112202: <http://trac.webkit.org/changeset/112202>

WebKit Review Bot

Comment 18 2012-03-26 20:51:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.