Bug 81432

Summary: Account for sample-rate in convolution normalization
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Chris Rogers <crogers>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+

Chris Rogers
Reported 2012-03-16 17:27:48 PDT
Account for sample-rate in convolution normalization
Attachments
Patch (2.72 KB, patch)
2012-03-16 17:31 PDT, Chris Rogers 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2012-03-16 17:30:03 PDT
Tested on many impulse-responses at 44.1KHz, 48KHz, and 96KHz to verify that volume differences are now fixed.
Chris Rogers
Comment 2 2012-03-16 17:31:02 PDT
Created attachment 132424 [details] Patch
James Robinson
Comment 3 2012-03-16 17:35:02 PDT
Comment on attachment 132424 [details] Patch OK. What's the state of testing for this sort of code?
Chris Rogers
Comment 4 2012-03-16 17:36:59 PDT
There's a generic convolution test which covers nearly all cases, but we still should write a more specialized test here.
Chris Rogers
Comment 5 2012-03-16 17:49:42 PDT
Committed r111100: <http://trac.webkit.org/changeset/111100>
Note You need to log in before you can comment on or make changes to this bug.