Bug 81432 - Account for sample-rate in convolution normalization
Summary: Account for sample-rate in convolution normalization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 17:27 PDT by Chris Rogers
Modified: 2012-03-16 17:49 PDT (History)
0 users

See Also:

Attachments
Patch (2.72 KB, patch)
2012-03-16 17:31 PDT, Chris Rogers 		jamesr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-03-16 17:27:48 PDT 
Account for sample-rate in convolution normalization
Comment 1 Chris Rogers 2012-03-16 17:30:03 PDT 
Tested on many impulse-responses at 44.1KHz, 48KHz, and 96KHz to verify that volume differences are now fixed.
Comment 2 Chris Rogers 2012-03-16 17:31:02 PDT 
Created attachment 132424 [details]
Patch
Comment 3 James Robinson 2012-03-16 17:35:02 PDT 
Comment on attachment 132424 [details]
Patch

OK. What's the state of testing for this sort of code?
Comment 4 Chris Rogers 2012-03-16 17:36:59 PDT 
There's a generic convolution test which covers nearly all cases, but we still should write a more specialized test here.
Comment 5 Chris Rogers 2012-03-16 17:49:42 PDT 
Committed r111100: <http://trac.webkit.org/changeset/111100>