Bug 8142

Summary:

fast/block/float/014.html test should not require live internet connection

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

Bug Blocks:

4508

Attachments:

Description	Flags
patch for fast/block/float/014.html	ggaren: review+
image for patch	none

Sam Weinig

Reported 2006-04-02 14:29:50 PDT

The layout tests fast/block/float/014.html and fast/loader/docLoaderFrame.html fail if your computer is not connected to the internet because they use external resources. This seems like a bad idea because it is both slower than using local resources and will not work if the external sources go down or change. If either really need http for some reason, mitz suggested moving it to use local httpd.

Attachments
patch for fast/block/float/014.html (1.71 KB, patch) 2006-04-17 13:18 PDT, Sam Weinig	ggaren: review+	Details Formatted Diff Diff
image for patch (1.39 KB, image/jpeg) 2006-04-17 14:00 PDT, Sam Weinig	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2006-04-17 13:18:22 PDT

Created attachment 7774 [details] patch for fast/block/float/014.html This fixes only one of the two problem files and requires adding a new folder (resources) and the image as well as the simple fix. The test fast/loader/docLoaderFrame.html requires moving it to the http folder and changing it to work there, neither of which I know how to do.

Geoffrey Garen

Comment 2 2006-04-17 13:42:27 PDT

Comment on attachment 7774 [details] patch for fast/block/float/014.html r=me to land, download http://www.macromedia.com/images/shared/editorial/60x45/training_thumb.jpg and put it in the right place

Sam Weinig

Comment 3 2006-04-17 14:00:19 PDT

Created attachment 7775 [details] image for patch The image needed for patch

Alexey Proskuryakov

Comment 4 2006-04-17 21:32:15 PDT