WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
4508
Layout tests access an external server
https://bugs.webkit.org/show_bug.cgi?id=4508
Summary
Layout tests access an external server
Alexey Proskuryakov
Reported
2005-08-18 09:55:53 PDT
layout-tests/fast/block/float/014.html uses an image from Macromedia web site: <img src="
http://www.macromedia.com/images/shared/editorial/60x45/training_thumb.jpg
" /> This test doesn't include a description of what's being tested, but accessing an outside server doesn't seem necessary...
Attachments
proposed fix
(10.84 KB, patch)
2006-09-02 09:12 PDT
,
Alexey Proskuryakov
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2005-08-18 10:02:19 PDT
One more: layout-tests/fast/lists/009.html list-style: disc url(
http://www.alistapart.com/i/listmark.gif
) inside;
Alexey Proskuryakov
Comment 2
2005-08-28 10:19:00 PDT
layout-tests/fast/lists/009.html was fixed on 2005-08-23 by Darin Adler, according to the ChangeLog. The other one is still there.
Alexey Proskuryakov
Comment 3
2005-10-02 11:28:31 PDT
Several of the newly-added XHTML tests access an external server (xw2k.sdct.itl.nist.gov), too: dom/xhtml/level2/html/HTMLBodyElement01.xhtml dom/xhtml/level2/html/HTMLBodyElement02.xhtml ... (searching in LayoutTests revealed 83 occurences of this URL)
Alexey Proskuryakov
Comment 4
2006-02-12 22:27:02 PST
dom/xhtml/level2/html tests have been fixed in
r12776
. The current list of offending tests is: fast/block/float/014.html fast/dom/HTMLImageElement/image-src-absolute-url.html fast/loader/docLoaderFrame.html
David Kilzer (:ddkilzer)
Comment 5
2006-03-17 05:19:24 PST
***
Bug 7825
has been marked as a duplicate of this bug. ***
Darin Adler
Comment 6
2006-04-18 09:25:01 PDT
After landing the fix for
bug 8142
, float/014 is fixed. So now image-src-absolute-url and docLoaderFrame are the two remaining.
Alexey Proskuryakov
Comment 7
2006-09-02 09:12:43 PDT
Created
attachment 10366
[details]
proposed fix
Alexey Proskuryakov
Comment 8
2006-09-02 11:49:44 PDT
It would also be good to prevent DumpRenderTree from accessing external resources now, but I'm not sure about the right approach.
Timothy Hatcher
Comment 9
2006-09-02 12:00:51 PDT
Comment on
attachment 10366
[details]
proposed fix Looks good. To prevent DRT from accessing external source you will need to hook up the resource load delegate and look at the URLs it tries to load, preventing remote URLs.
Alexey Proskuryakov
Comment 10
2006-09-03 02:07:21 PDT
Filed
bug 10707
for DRT enhancements.
Alexey Proskuryakov
Comment 11
2006-09-03 02:19:19 PDT
Committed revision 16196.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug