Bug 81383

Summary: [chromium] Adding support for GL_EXT_discard_framebuffer.
Product: WebKit Reporter: Michal Mocny <mmocny>
Component: New BugsAssignee: Michal Mocny <mmocny>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, enne, fishd, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Michal Mocny 2012-03-16 11:54:13 PDT
[chromium] Adding support for GL_EXT_discard_framebuffer.
Comment 1 Michal Mocny 2012-03-16 11:58:56 PDT
Created attachment 132338 [details]
Patch
Comment 2 Michal Mocny 2012-03-16 12:02:45 PDT
Comment on attachment 132338 [details]
Patch

This is the other WebGraphicsContext3D extension needed for compositor memory allocation changed callback handler.  (The other is https://bugs.webkit.org/show_bug.cgi?id=81279)
Comment 3 WebKit Review Bot 2012-03-16 13:13:09 PDT
Please wait for approval from fishd@chromium.org, abarth@webkit.org or jamesr@chromium.org before submitting because this patch contains changes to the Chromium platform API.
Comment 4 Michal Mocny 2012-03-16 13:26:20 PDT
Comment on attachment 132338 [details]
Patch

This cl will change, as the extension is going to have some arguments to better mirror http://www.khronos.org/registry/gles/extensions/EXT/EXT_discard_framebuffer.txt
Comment 5 Michal Mocny 2012-03-19 08:11:48 PDT
Created attachment 132587 [details]
Patch
Comment 6 Michal Mocny 2012-03-19 08:15:10 PDT
Comment on attachment 132587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132587&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:162
> +    virtual void ensureFramebufferCHROMIUM() { }

This is a chromium extension to the discard framebuffer extension which is very likely to be removed once we support the automatic recreation of backbuffer upon first use.
Due to the time pressure for getting this in, it is unlikely to happen before M19, hence this explicit call.

Is it alright to share the single "GL_EXT_discard_framebuffer" string, or shall I add a "GL_CHROMIUM_ensure_framebuffer"?
Comment 7 Nat Duca 2012-03-19 11:33:35 PDT
Comment on attachment 132587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132587&action=review

LGTM. @enne or @jamesr for review.

>> Source/Platform/chromium/public/WebGraphicsContext3D.h:162
>> +    virtual void ensureFramebufferCHROMIUM() { }
> 
> This is a chromium extension to the discard framebuffer extension which is very likely to be removed once we support the automatic recreation of backbuffer upon first use.
> Due to the time pressure for getting this in, it is unlikely to happen before M19, hence this explicit call.
> 
> Is it alright to share the single "GL_EXT_discard_framebuffer" string, or shall I add a "GL_CHROMIUM_ensure_framebuffer"?

Seems fine
Comment 8 WebKit Review Bot 2012-03-19 19:26:11 PDT
Comment on attachment 132587 [details]
Patch

Clearing flags on attachment: 132587

Committed r111312: <http://trac.webkit.org/changeset/111312>
Comment 9 WebKit Review Bot 2012-03-19 19:26:15 PDT
All reviewed patches have been landed.  Closing bug.