Bug 81373

Summary: [BlackBerry] Implement openTemporaryFile in FileSystem
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, staikos, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch staikos: review+

Description Rob Buis 2012-03-16 11:00:56 PDT
We currently lack an implementation:

String openTemporaryFile(const String&, PlatformFileHandle&)
{
    return "";
}
Comment 1 Rob Buis 2012-03-16 11:10:25 PDT
Created attachment 132322 [details]
Patch
Comment 2 Rob Buis 2012-03-16 11:27:15 PDT
I added the Efl folks on CC to make sure they would be ok with the change. I also wonder if I left out anybody from the posix group?
Comment 3 Rob Buis 2012-03-16 12:22:29 PDT
Created attachment 132344 [details]
Patch
Comment 4 Rob Buis 2012-03-16 15:27:58 PDT
Created attachment 132396 [details]
Patch
Comment 5 Rob Buis 2012-03-17 12:18:57 PDT
The patch seems to work on the buildbots now :)
Comment 6 George Staikos 2012-03-17 12:39:44 PDT
Comment on attachment 132396 [details]
Patch

Presuming that EFL builds the POSIX file, which it seems to based on the bots, this is good for me.  I wish the goto would go away though.
Comment 7 Rob Buis 2012-03-19 07:24:02 PDT
Landed as r111127.