Bug 81370

Summary:

IndexedDB: LayoutTests don't need explicit console div

Product:

WebKit

Reporter:

Joshua Bell <jsbell>

Component:

WebKit Misc.

Assignee:

Joshua Bell <jsbell>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dgrogan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Joshua Bell

Reported 2012-03-16 10:48:29 PDT

All of storage/indexeddb/*.html files include <div id="console"></div> - this is created on the fly by js-test-pre.js if necessary and can be removed from the HTML file.

Attachments
Patch (61.63 KB, patch) 2012-03-16 12:21 PDT, Joshua Bell	no flags	Details Formatted Diff Diff
Patch for landing (85.89 KB, patch) 2012-03-19 10:59 PDT, Joshua Bell	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joshua Bell

Comment 1 2012-03-16 11:12:20 PDT

Ditto for <p id="description"></p> Also, can remove explicit jsTestIsAsync = true, for scripts that include shared.js

Joshua Bell

Comment 2 2012-03-16 12:21:25 PDT

Created attachment 132342 [details] Patch

Joshua Bell

Comment 3 2012-03-16 12:22:53 PDT

perl -pnie FTW. The handful of *-expected.txt changes are for few blank lines that disappear, and line numbers for expected exceptions.

David Grogan

Comment 4 2012-03-16 12:24:29 PDT

LGTM

Tony Chang

Comment 5 2012-03-16 13:13:55 PDT

Comment on attachment 132342 [details] Patch rs=me

Joshua Bell

Comment 6 2012-03-19 10:59:27 PDT

Created attachment 132608 [details] Patch for landing

WebKit Review Bot

Comment 7 2012-03-19 11:39:38 PDT

Comment on attachment 132608 [details] Patch for landing Clearing flags on attachment: 132608 Committed r111211: <http://trac.webkit.org/changeset/111211>

WebKit Review Bot

Comment 8 2012-03-19 11:39:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.