Summary: | [BlackBerry] Input fields with id of e-mail and url should be styled as such. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Fenton <mifenton> | ||||||||
Component: | WebKit BlackBerry | Assignee: | Mike Fenton <mifenton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mike Fenton
2012-03-16 10:08:07 PDT
Created attachment 132308 [details]
Patch
Comment on attachment 132308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132308&action=review Looks good. > Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:347 > +} Above two function could use the same helper function, but you'd need to add a bool or enum indicating to test Email or Url. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:191 > + else if ((type == InputTypeEmail || type == InputTypeURL) && autoCompleteState != DOMSupport::On) else seems unnecessary here. Comment on attachment 132308 [details] Patch Clearing flags on attachment: 132308 Committed r111037: <http://trac.webkit.org/changeset/111037> All reviewed patches have been landed. Closing bug. Created attachment 132355 [details]
Follow up patch
Comment on attachment 132355 [details]
Follow up patch
Even better :)
Created attachment 132357 [details]
Proper follow up patch.
Comment on attachment 132357 [details]
Proper follow up patch.
OK.
Reopen so commit bot will grab it. Comment on attachment 132357 [details] Proper follow up patch. Clearing flags on attachment: 132357 Committed r111206: <http://trac.webkit.org/changeset/111206> All reviewed patches have been landed. Closing bug. |