Bug 81360

Summary: [chromium] Improve CSS3 filters performance for blur() and drop-shadow().
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jamesr: review+

Stephen White
Reported 2012-03-16 09:29:11 PDT
[chromium] Improve CSS3 filters performance for blur() and drop-shadow().
Attachments
Patch (2.35 KB, patch)
2012-03-16 09:30 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2012-03-16 09:43 PDT, Stephen White 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2012-03-16 09:30:45 PDT
Created attachment 132296 [details] Patch
Stephen White
Comment 2 2012-03-16 09:43:29 PDT
Created attachment 132300 [details] Patch
Stephen White
Comment 3 2012-03-16 09:44:12 PDT
(In reply to comment #2) > Created an attachment (id=132300) [details] > Patch With the previous change, drop-shadow() was showing some truncated pixels on the layout tests, so I've reverted that part of the change.
James Robinson
Comment 4 2012-03-16 12:23:31 PDT
Comment on attachment 132300 [details] Patch Cool
Stephen White
Comment 5 2012-03-16 12:45:19 PDT
Committed r111047: <http://trac.webkit.org/changeset/111047>
James Robinson
Comment 6 2012-03-16 20:39:51 PDT
compositing/shadows/shadow-drawing.html changed behavior on windows with this patch: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=compositing%2Fshadows%2Fshadow-drawing.html I kinda think the new results look better, but could you take a look?
Stephen White
Comment 7 2012-03-16 21:08:56 PDT
(In reply to comment #6) > compositing/shadows/shadow-drawing.html changed behavior on windows with this patch: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&tests=compositing%2Fshadows%2Fshadow-drawing.html > > I kinda think the new results look better, but could you take a look? This test has no -webkit-filter, so I think it must be something else. Not sure what's going on, but if you look at the Vista results, they changed at http://trac.webkit.org/log/?verbose=on&rev=111013&stop_rev=111012.
Note You need to log in before you can comment on or make changes to this bug.