Summary: | Move parse_bug_id into config/urls in preparation for re-use elsewhere. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ojan, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2012-03-15 23:07:50 PDT
Created attachment 132206 [details]
Patch
Comment on attachment 132206 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132206&action=review > Tools/Scripts/webkitpy/common/config/urls.py:56 > +def parse_bug_id(message): message ? Not sure what the best parameter name is here. > Tools/Scripts/webkitpy/common/config/urls_unittest.py:35 > + def test_parse_bug_id(self): Should we add any multiline test cases since that's needed by at least one caller. Committed r110948: <http://trac.webkit.org/changeset/110948> |