Bug 81312 – [BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Leo Yang]

BlackBerry specific change to keyboard event.

[Leo Yang]

Created attachment 132214 [details]
Patch

[Build Bot]

Comment on attachment 132214 [details]
Patch

Attachment 132214 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/11964047

[Leo Yang]

(In reply to comment #2)
> (From update of attachment 132214 [details])
> Attachment 132214 [details] did not pass mac-ews (mac):
> Output: http://queues.webkit.org/results/11964047

Seems not related to this patch.

[Rob Buis]

Comment on attachment 132214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review

> Source/WebCore/platform/PlatformKeyboardEvent.h:195
> +        unsigned short m_unmodifiedCharacter;

How is m_unmodifiedCharacter used? It seems to be set to zero and then?

[Leo Yang]

(In reply to comment #4)
> (From update of attachment 132214 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review
> 
> > Source/WebCore/platform/PlatformKeyboardEvent.h:195
> > +        unsigned short m_unmodifiedCharacter;
> 
> How is m_unmodifiedCharacter used? It seems to be set to zero and then?

It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp.

[Rob Buis]

Comment on attachment 132214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review

LGTM.

>>> Source/WebCore/platform/PlatformKeyboardEvent.h:195
>>> +        unsigned short m_unmodifiedCharacter;
>> 
>> It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp.
> 
> How is m_unmodifiedCharacter used? It seems to be set to zero and then?

Ah, this was not visible from the context, I saw it just now in the source file, thanks.

[WebKit Review Bot]

Comment on attachment 132214 [details]
Patch

Clearing flags on attachment: 132214

Committed r111191: <http://trac.webkit.org/changeset/111191>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.