Summary: | [BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leo Yang <leo.yang> | ||||
Component: | WebKit BlackBerry | Assignee: | Leo Yang <leo.yang> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 73144 | ||||||
Attachments: |
|
Description
Leo Yang
2012-03-15 23:07:30 PDT
Created attachment 132214 [details]
Patch
Comment on attachment 132214 [details] Patch Attachment 132214 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11964047 (In reply to comment #2) > (From update of attachment 132214 [details]) > Attachment 132214 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/11964047 Seems not related to this patch. Comment on attachment 132214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review > Source/WebCore/platform/PlatformKeyboardEvent.h:195 > + unsigned short m_unmodifiedCharacter; How is m_unmodifiedCharacter used? It seems to be set to zero and then? (In reply to comment #4) > (From update of attachment 132214 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review > > > Source/WebCore/platform/PlatformKeyboardEvent.h:195 > > + unsigned short m_unmodifiedCharacter; > > How is m_unmodifiedCharacter used? It seems to be set to zero and then? It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp. Comment on attachment 132214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132214&action=review LGTM. >>> Source/WebCore/platform/PlatformKeyboardEvent.h:195 >>> + unsigned short m_unmodifiedCharacter; >> >> It's initialized by event.character() in PlatformKeyboardEvent::PlatformKeyboardEvent(const BlackBerry::Platform::KeyboardEvent& event) in PlatformKeyboardEventBlackBerry.cpp and used in PluginView::handleKeyboardEvent(KeyboardEvent* event) in PluginViewBlackBerry.cpp. > > How is m_unmodifiedCharacter used? It seems to be set to zero and then? Ah, this was not visible from the context, I saw it just now in the source file, thanks. Comment on attachment 132214 [details] Patch Clearing flags on attachment: 132214 Committed r111191: <http://trac.webkit.org/changeset/111191> All reviewed patches have been landed. Closing bug. |