Bug 81294

Summary:

Web Inspector: TypeBuilder: reduce raw methods visibility in generated types.

Product:

WebKit

Reporter:

Peter Rybin <prybin>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

bburg, bweinstein, joepeck, pmuellr, rik, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review-

Description Peter Rybin 2012-03-15 17:42:03 PDT

Currently both typed generated methods and raw setters are available for generated types. Hide raw setters so that make sure that only documented properties are set.

Comment 1 Peter Rybin 2012-03-15 18:01:38 PDT

Created attachment 132166 [details]
Patch

Comment 2 Pavel Feldman 2012-03-20 04:45:25 PDT

Comment on attachment 132166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132166&action=review

One nit + you should run it through EWS.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1229
> +            //COMPILE_ASSERT(false, weird_old_code);

We don't commit commented out code.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1247
> +        // return Builder<NoFieldsSet>(adoptRef(new %s()));

ditto

Comment 3 Radar WebKit Bug Importer 2014-01-26 11:12:31 PST

<rdar://problem/15911127>