Bug 81271
| Summary: | WebViewImpl.cpp should no include my mother's kitchen sink | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | abarth, ahmad.saleem792, ap, dbates, fishd |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Eric Seidel (no email)
WebViewImpl.cpp should no include my mother's kitchen sink
Any time one has 124 #include statements in a file... well... "we're doing it wrong". :)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Is it for `WebViewImpl.mm` since WebKit don't have `WebViewImpl.cpp`?
https://searchfox.org/wubkat/rev/c67bb750f2c1083399f0dbe7d08b416cd45eee34/Source/WebKit/UIProcess/mac/WebViewImpl.mm
@Alexey - any input?
Alexey Proskuryakov
We've had several include hygiene projects completed since then, this bug is not serving any purpose at this point.