Bug 8123

Summary:

focus outline on new text field doesn't look like the old one

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Forms

Assignee:

Darin Adler <darin>

Status:

RESOLVED DUPLICATE

Severity:

Major

CC:

adele, hyatt

Priority:

Keywords:

InRadar, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch with detailed change log	none
patch with detailed change log -- also deals with blue/graphite appearance	adele: review+

Darin Adler

Reported 2006-04-01 13:18:36 PST

We need to change the new text field so the outline is exactly like the old one.

Attachments
patch with detailed change log (10.42 KB, patch) 2006-04-01 13:30 PST, Darin Adler	no flags	Details Formatted Diff Diff
patch with detailed change log -- also deals with blue/graphite appearance (65.16 KB, patch) 2006-04-01 22:13 PST, Darin Adler	adele: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2006-04-01 13:30:19 PST

Created attachment 7445 [details] patch with detailed change log

Darin Adler

Comment 2 2006-04-01 22:13:04 PST

Created attachment 7455 [details] patch with detailed change log -- also deals with blue/graphite appearance

Adele Peterson

Comment 3 2006-04-02 12:12:50 PDT

Comment on attachment 7455 [details] patch with detailed change log -- also deals with blue/graphite appearance r=me, assuming you talk to Hyatt about the strict mode issue at some point :)

Eric Seidel (no email)

Comment 4 2006-04-02 16:13:25 PDT

Has this landed? Something recently caused the pixel tests to regress wrt focus rings: http://build.webkit.org/results/post-commit-pixel-powerpc-mac-os-x/128/

Darin Adler

Comment 5 2006-04-02 17:54:10 PDT

(In reply to comment #4) > Has this landed? No, but I'm landing it right now, along with new pixel test results. > Something recently caused the pixel tests to regress wrt focus rings: > http://build.webkit.org/results/post-commit-pixel-powerpc-mac-os-x/128/ That was the WebKitSystemInterface change, which was a precursor to this one. I knew it would change the appearance of focus rings; sorry, I forgot to mention that to you.

Dave Hyatt

Comment 6 2006-04-02 23:13:51 PDT

outline-offset is an actual CSS property. By changing it to accept negative values, we now violate the spec. We need to log this as an issue in our bug database so that we can lobby to get the spec changed. If not, we will have to change outline-offset to -khtml-outline-offset before shipping.

Maciej Stachowiak

Comment 7 2006-04-02 23:50:47 PDT

In Radar as <rdar://problem/4497131>

Dave Hyatt

Comment 8 2006-04-03 00:07:27 PDT

Actually nvm. It looks like the restriction does not exist any more in the current spec.

Darin Adler

Comment 9 2006-04-03 15:16:31 PDT

*** This bug has been marked as a duplicate of 8093 ***

Note You need to log in before you can comment on or make changes to this bug.