Bug 81220

Summary: [EFL] Implement LayoutTestController::setMinimumTimerInterval
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, pnormand, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Implement setMinimumTimerInterval and enable related tests.
pnormand: review-, pnormand: commit-queue-
Patch none

Sudarsana Nagineni (babu)
Reported 2012-03-15 07:49:04 PDT
Implement LayoutTestController::setMinimumTimerInterval for EFL port so that we can unskip related tests from the skip list.
Attachments
Implement setMinimumTimerInterval and enable related tests. (2.83 KB, patch)
2012-03-15 08:13 PDT, Sudarsana Nagineni (babu) 		pnormand: review-
pnormand: commit-queue-
DetailsFormatted DiffDiff
Patch (2.82 KB, patch)
2012-03-30 01:49 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-03-15 08:13:55 PDT
Created attachment 132051 [details] Implement setMinimumTimerInterval and enable related tests.
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-03-15 08:23:53 PDT
Comment on attachment 132051 [details] Implement setMinimumTimerInterval and enable related tests. Looks good, thanks.
Gyuyoung Kim
Comment 3 2012-03-15 23:47:38 PDT
Comment on attachment 132051 [details] Implement setMinimumTimerInterval and enable related tests. LGTM too.
Philippe Normand
Comment 4 2012-03-30 01:24:14 PDT
Comment on attachment 132051 [details] Implement setMinimumTimerInterval and enable related tests. View in context: https://bugs.webkit.org/attachment.cgi?id=132051&action=review > Tools/ChangeLog:12 > + (LayoutTestController::setMinimumTimerInterval): Implemented. "Implemented" here doesn't add much explanation to the changelog entry. Eithere remove it or provide a suitable explanation.
Sudarsana Nagineni (babu)
Comment 5 2012-03-30 01:48:13 PDT
(In reply to comment #4) > (From update of attachment 132051 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132051&action=review > > > Tools/ChangeLog:12 > > + (LayoutTestController::setMinimumTimerInterval): Implemented. > > "Implemented" here doesn't add much explanation to the changelog entry. Eithere remove it or provide a suitable explanation. Description is already there in the changelog, so I will remove it. Thanks for your review!
Sudarsana Nagineni (babu)
Comment 6 2012-03-30 01:49:59 PDT
Created attachment 134745 [details] Patch Fix changelog entry.
WebKit Review Bot
Comment 7 2012-03-30 02:46:22 PDT
Comment on attachment 134745 [details] Patch Clearing flags on attachment: 134745 Committed r112647: <http://trac.webkit.org/changeset/112647>
WebKit Review Bot
Comment 8 2012-03-30 02:46:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.