Bug 8121

Summary:

REGRESSION: 404s are not displayed

Product:

WebKit

Reporter:

Denis Defreyne <amonre>

Component:

WebKit Misc.

Assignee:

Trey Matteson <trey>

Status:

RESOLVED FIXED

Severity:

Major

CC:

ap, trey

Priority:

Keywords:

Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.apple.com/akjwfelwajkfwajfkewwefawegawef

Attachments:

Description	Flags
proposed patch	none
proposed patch	mjs: review+

Denis Defreyne

Reported 2006-04-01 11:51:25 PST

OVERVIEW: Latest nightly is unable to show 404 pages. STEPS TO REPRODUCE: Go to a nonexistant page, such as <http://www.apple.com/akjwfelwajkfwajfkewwefawegawef>. ACTUAL RESULTS: Safari stops loading the page before anything gets displayed. The window stays completely empty. The status bar displays "Cancelled loading the page." BUILD INFORMATION: This bug appears in r13626.

Attachments
proposed patch (15.07 KB, patch) 2006-04-02 17:56 PDT, Trey Matteson	no flags	Details Formatted Diff Diff
proposed patch (16.01 KB, patch) 2006-04-02 21:01 PDT, Trey Matteson	mjs: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2006-04-01 12:10:19 PST

Confirmed with r13615.

Alexey Proskuryakov

Comment 2 2006-04-02 05:05:41 PDT

Caused by the fix in bug 7739 (TOT REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]).

Trey Matteson

Comment 3 2006-04-02 10:48:40 PDT

I will take a look.

Trey Matteson

Comment 4 2006-04-02 17:55:28 PDT

Fixed by limiting the previous change to the case of an <object> element. I also added a couple test cases for this area, and tweaked the test harness to allow Perl files to be executed as tests (so as to generate a specific 404 error).

Trey Matteson

Comment 5 2006-04-02 17:56:16 PDT

Created attachment 7472 [details] proposed patch

Darin Adler

Comment 6 2006-04-02 18:57:54 PDT

Comment on attachment 7472 [details] proposed patch + return element ? [DOMElement _elementWith:element] : nil; No need for this ?: expression here. The method _elementWith: handles this case, yielding nil. I know you copied it from the _ownerElement method, which also doesn't need it!

Trey Matteson

Comment 7 2006-04-02 21:01:32 PDT

Created attachment 7474 [details] proposed patch Yep, that's where I copied it from. Same patch with the extra nil checks removed from both places, and [WebCoreFrameBridge currentForm] to boot.

Maciej Stachowiak

Comment 8 2006-04-03 02:47:16 PDT

Comment on attachment 7474 [details] proposed patch r=me

Darin Adler

Comment 9 2006-04-03 09:15:14 PDT

I applied the patch, and it clearly does fix real 404 erors. But I can't get the new layout tests to pass, so I can't land yet.

Darin Adler

Comment 10 2006-04-03 09:22:11 PDT

(In reply to comment #9) > But I can't get the new layout tests to pass, so I can't land yet. It was a permission problem. Fixed now.

Note You need to log in before you can comment on or make changes to this bug.