OVERVIEW: Latest nightly is unable to show 404 pages. STEPS TO REPRODUCE: Go to a nonexistant page, such as <http://www.apple.com/akjwfelwajkfwajfkewwefawegawef>. ACTUAL RESULTS: Safari stops loading the page before anything gets displayed. The window stays completely empty. The status bar displays "Cancelled loading the page." BUILD INFORMATION: This bug appears in r13626.
Confirmed with r13615.
Caused by the fix in bug 7739 (TOT REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]).
I will take a look.
Fixed by limiting the previous change to the case of an <object> element. I also added a couple test cases for this area, and tweaked the test harness to allow Perl files to be executed as tests (so as to generate a specific 404 error).
Created attachment 7472 [details] proposed patch
Comment on attachment 7472 [details] proposed patch + return element ? [DOMElement _elementWith:element] : nil; No need for this ?: expression here. The method _elementWith: handles this case, yielding nil. I know you copied it from the _ownerElement method, which also doesn't need it!
Created attachment 7474 [details] proposed patch Yep, that's where I copied it from. Same patch with the extra nil checks removed from both places, and [WebCoreFrameBridge currentForm] to boot.
Comment on attachment 7474 [details] proposed patch r=me
I applied the patch, and it clearly does fix real 404 erors. But I can't get the new layout tests to pass, so I can't land yet.
(In reply to comment #9) > But I can't get the new layout tests to pass, so I can't land yet. It was a permission problem. Fixed now.