Bug 81207

Summary: MediaStream API (JSEP): Introducing MediaHints and IceOptions
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: harald, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 80589    
Attachments:
Description Flags
Patch none

Description Tommy Widenflycht 2012-03-15 04:24:54 PDT 
Introducing the platform MediaHints and IceOptions helper classes.
Comment 1 Tommy Widenflycht 2012-03-15 05:03:08 PDT 
Created attachment 132021 [details]
Patch
Comment 2 Adam Barth 2012-03-15 10:59:37 PDT 
Comment on attachment 132021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132021&action=review

> Source/WebCore/platform/mediastream/IceOptions.h:55
> +    IceOptions(UseCandidatesOption useCandidates) : m_useCandidates(useCandidates) { }

One-argument constructors should have the "explicit" keyword.
Comment 3 Adam Barth 2012-03-15 11:00:18 PDT 
Comment on attachment 132021 [details]
Patch

Please consider addressing these nits in a follow-up patch.
Comment 4 WebKit Review Bot 2012-03-15 20:45:46 PDT 
Comment on attachment 132021 [details]
Patch

Clearing flags on attachment: 132021

Committed r110937: <http://trac.webkit.org/changeset/110937>
Comment 5 WebKit Review Bot 2012-03-15 20:45:50 PDT 
All reviewed patches have been landed.  Closing bug.