| Summary: | Typed Array create() methods do not accept const arrays | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Dorwin <ddorwin> | ||||
| Component: | JavaScriptCore | Assignee: | David Dorwin <ddorwin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, kbr, oliver, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 131908 [details]
Patch
Comment on attachment 131908 [details]
Patch
Thanks for fixing this. r=me
Comment on attachment 131908 [details] Patch Clearing flags on attachment: 131908 Committed r110913: <http://trac.webkit.org/changeset/110913> All reviewed patches have been landed. Closing bug. |
Many of the Typed Arrays (classes derived from TypedArrayBase) do not allow a pointer to a const array to be passed to the create method. For example: static inline PassRefPtr<Uint8Array> create(unsigned char* array, unsigned length); These methods use static PassRefPtr<Subclass> create(const T* array, unsigned length) so there is no reason the type of the first parameter cannot be const. The example above should be: static inline PassRefPtr<Uint8Array> create(const unsigned char* array, unsigned length);