Bug 81132

Summary: Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Peter Rybin
Reported 2012-03-14 10:24:21 PDT
Throughout inspector codebase most of .cpp file contain ENABLE(INSPECTOR) guards. However corresponding .h files are often included before this guard, i.e. unconditionally. There is a strange implication here that .h files should turn out to be compilable even when INSPECTOR is no enabled. Since this implication often becomes wrong with development going on, all .h files should go behind ENABLE(INSPECTOR) guards.
Attachments
Patch (29.17 KB, patch)
2012-03-14 11:26 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Patch (29.14 KB, patch)
2012-03-14 15:52 PDT, Peter Rybin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Rybin
Comment 1 2012-03-14 11:26:31 PDT
Created attachment 131889 [details] Patch
Peter Rybin
Comment 2 2012-03-14 15:52:17 PDT
Created attachment 131944 [details] Patch
Yury Semikhatsky
Comment 3 2012-03-15 09:44:54 PDT
Comment on attachment 131944 [details] Patch Clearing flags on attachment: 131944 Committed r110854: <http://trac.webkit.org/changeset/110854>
Yury Semikhatsky
Comment 4 2012-03-15 09:45:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.