Bug 81124

Summary: [EFL] Implement LayoutTestController::setEditingBehavior
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 80126    
Bug Blocks: 81130    
Attachments:
Description Flags
Implement setEditingBehavior
gyuyoung.kim: commit-queue-
Patch
none
Patch none

Description Sudarsana Nagineni (babu) 2012-03-14 09:23:28 PDT
Implement LayoutTestController::setEditingBehavior for EFL port so that we can unskip related tests from the skip list.
Comment 1 Sudarsana Nagineni (babu) 2012-03-14 09:41:46 PDT
Created attachment 131870 [details]
Implement setEditingBehavior
Comment 2 Gyuyoung Kim 2012-03-14 17:41:11 PDT
Comment on attachment 131870 [details]
Implement setEditingBehavior

Attachment 131870 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11953551
Comment 3 Gyuyoung Kim 2012-03-14 19:00:38 PDT
Comment on attachment 131870 [details]
Implement setEditingBehavior

View in context: https://bugs.webkit.org/attachment.cgi?id=131870&action=review

> LayoutTests/platform/efl/Skipped:736
> +# Set unicode backspace value in EFL's createKeyMaap

Minor nit : %s/createKeyMaap/createKeyMap/g

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722
> +        ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN);

EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared.
Comment 4 Sudarsana Nagineni (babu) 2012-03-14 23:07:56 PDT
(In reply to comment #3)

Thanks for your review!

> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722
> > +        ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN);
> 
> EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared.

This is dependent on bug #80126 fix.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-03-21 11:50:56 PDT
*** Bug 80126 has been marked as a duplicate of this bug. ***
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-03-21 11:51:56 PDT
(In reply to comment #5)
> *** Bug 80126 has been marked as a duplicate of this bug. ***

As discussed in bug 80126, we're not adding anything to ewk_view anymore; instead, we're just adding some API to DumpRenderTreeSupportEfl. As it's all related to setEditingBehavior, it makes more sense to land everything in a single patch.
Comment 7 Sudarsana Nagineni (babu) 2012-03-21 11:56:28 PDT
Created attachment 133087 [details]
Patch

Merged 80126 fix into this one.
Comment 8 Raphael Kubo da Costa (:rakuco) 2012-03-21 11:58:17 PDT
Comment on attachment 133087 [details]
Patch

Looks fine, thanks.
Comment 9 Martin Robinson 2012-03-22 07:26:04 PDT
Comment on attachment 133087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133087&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:428
> +    else
> +        return;

Maybe it would be good to put an ASSERT_NOT_REACHED here?
Comment 10 Sudarsana Nagineni (babu) 2012-03-22 07:47:46 PDT
Created attachment 133263 [details]
Patch

fixed comment #9.
Comment 11 WebKit Review Bot 2012-03-22 08:51:03 PDT
Comment on attachment 133263 [details]
Patch

Clearing flags on attachment: 133263

Committed r111709: <http://trac.webkit.org/changeset/111709>
Comment 12 WebKit Review Bot 2012-03-22 08:51:09 PDT
All reviewed patches have been landed.  Closing bug.