Summary: | [EFL] Implement LayoutTestController::setEditingBehavior | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sudarsana Nagineni (babu) <naginenis> | ||||||||
Component: | WebKit EFL | Assignee: | Sudarsana Nagineni (babu) <naginenis> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 80126 | ||||||||||
Bug Blocks: | 81130 | ||||||||||
Attachments: |
|
Description
Sudarsana Nagineni (babu)
2012-03-14 09:23:28 PDT
Created attachment 131870 [details]
Implement setEditingBehavior
Comment on attachment 131870 [details] Implement setEditingBehavior Attachment 131870 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11953551 Comment on attachment 131870 [details] Implement setEditingBehavior View in context: https://bugs.webkit.org/attachment.cgi?id=131870&action=review > LayoutTests/platform/efl/Skipped:736 > +# Set unicode backspace value in EFL's createKeyMaap Minor nit : %s/createKeyMaap/createKeyMap/g > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722 > + ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN); EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared. (In reply to comment #3) Thanks for your review! > > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:722 > > + ewk_view_setting_editing_behavior_set(browser->mainView(), EWK_EDITING_BEHAVIOR_WIN); > > EWS reported that EWK_EDITING_BEHAVIOR_XXX is not declared. This is dependent on bug #80126 fix. *** Bug 80126 has been marked as a duplicate of this bug. *** (In reply to comment #5) > *** Bug 80126 has been marked as a duplicate of this bug. *** As discussed in bug 80126, we're not adding anything to ewk_view anymore; instead, we're just adding some API to DumpRenderTreeSupportEfl. As it's all related to setEditingBehavior, it makes more sense to land everything in a single patch. Created attachment 133087 [details]
Patch
Merged 80126 fix into this one.
Comment on attachment 133087 [details]
Patch
Looks fine, thanks.
Comment on attachment 133087 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=133087&action=review > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:428 > + else > + return; Maybe it would be good to put an ASSERT_NOT_REACHED here? Created attachment 133263 [details] Patch fixed comment #9. Comment on attachment 133263 [details] Patch Clearing flags on attachment: 133263 Committed r111709: <http://trac.webkit.org/changeset/111709> All reviewed patches have been landed. Closing bug. |