Bug 81107

Summary: [Qt] RenderThemeQt::fileListNameForWidth should override function in base class RenderTheme. (r110560)
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit2Assignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for review. none

Zeno Albisser
Reported 2012-03-14 07:52:48 PDT
RenderThemeQt::fileListNameForWidth() misses a parameter to properly override RenderTheme::fileListNameForWidth(). This becomes obvious after r110560 where the OVERRIDE keyword has been added to the function declaration. fileListNameForWidth() is only called in one place (WebCore/rendering/RenderFileUploadControl.cpp:244) and there it is called with the currently missing parameter "bool multipleFilesAllowed". Therefore we can assume that the implementation RenderThemeQt::fileListNameForWidth() never actually happens to be called currently.
Attachments
patch for review. (2.31 KB, patch)
2012-03-14 08:13 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2012-03-14 08:13:10 PDT
Created attachment 131850 [details] patch for review.
Zeno Albisser
Comment 2 2012-03-15 16:29:12 PDT
Comment on attachment 131850 [details] patch for review. Clearing flags on attachment: 131850 Committed r110907: <http://trac.webkit.org/changeset/110907>
Zeno Albisser
Comment 3 2012-03-15 16:29:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.