Bug 81100

Summary: Web Inspector: use class name indexes instead of class names when evaluating aggregates
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Yury Semikhatsky 2012-03-14 06:20:48 PDT 
Use class name indexes instead of class names when evaluating aggregates. Class name lookup followed by string comparison takes significantly longer time then comparison of the class name indexes. For node type comparison it is also much faster to compare its integer value instead of strings.
Comment 1 Yury Semikhatsky 2012-03-14 06:25:06 PDT 
Created attachment 131835 [details]
Patch
Comment 2 Yury Semikhatsky 2012-03-14 06:56:10 PDT 
Comment on attachment 131835 [details]
Patch

Please ignore this patch.
Comment 3 Yury Semikhatsky 2012-03-14 08:50:58 PDT 
Created attachment 131863 [details]
Patch
Comment 4 Yury Semikhatsky 2012-03-14 08:52:25 PDT 
This patch makes _buildAggregates ~ 35% faster.
Comment 5 Ilya Tikhonovsky 2012-03-14 08:58:16 PDT 
Comment on attachment 131863 [details]
Patch

lgtm
Comment 6 Yury Semikhatsky 2012-03-14 09:20:53 PDT 
Committed r110707: <http://trac.webkit.org/changeset/110707>