Bug 81087

Summary: Don't install libWebCoreTestSupport on OS X production builds
Product: WebKit Reporter: Matt Lilek <dev+webkit>
Component: WebCore Misc.Assignee: Matt Lilek <dev+webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
patch
mrowe: review-, dev+webkit: commit-queue-
patch2 mrowe: review+, dev+webkit: commit-queue-

Matt Lilek
Reported 2012-03-14 00:46:11 PDT
No reason to install this dylib on production builds. <rdar://problem/10501894>
Attachments
patch (1.23 KB, patch)
2012-03-14 00:53 PDT, Matt Lilek 		mrowe: review-
dev+webkit: commit-queue-
DetailsFormatted DiffDiff
patch2 (1.27 KB, patch)
2012-03-16 13:39 PDT, Matt Lilek 		mrowe: review+
dev+webkit: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Lilek
Comment 1 2012-03-14 00:53:08 PDT
Created attachment 131801 [details] patch
Mark Rowe (bdash)
Comment 2 2012-03-14 01:14:42 PDT
Comment on attachment 131801 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=131801&action=review > Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:35 > +SKIP_INSTALL = $(SKIP_INSTALL_$(BUILD_TYPE)); > +SKIP_INSTALL_Production = YES; I don't know what BUILD_TYPE is. It wouldn't be what we want anyway. Since this library is only used by DumpRenderTree and friends we want this installed only when FORCE_TOOL_INSTALL = YES. See Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig for where we do this elsewhere.
Matt Lilek
Comment 3 2012-03-15 15:38:18 PDT
BUILD_TYPE was a typo. But the way ToolExecutable does it is even better. New patch forthcoming.
Matt Lilek
Comment 4 2012-03-16 13:39:09 PDT
Created attachment 132362 [details] patch2
Matt Lilek
Comment 5 2012-03-16 13:48:35 PDT
http://trac.webkit.org/changeset/111058
Note You need to log in before you can comment on or make changes to this bug.