Summary: | [Chromium] REGRESSION(r110596) CCQuadCullerTest.verifyCullChildLinesUpTopLeft fails on Windows | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||
Component: | Platform | Assignee: | Dana Jansens <danakj> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | backer, cc-bugs, danakj, enne, jamesr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 80743 | ||||||||
Attachments: |
|
Description
Hajime Morrita
2012-03-13 23:56:17 PDT
Marked as fails at http://trac.webkit.org/changeset/110666 Created attachment 131847 [details]
Patch
Comment on attachment 131847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131847&action=review > Source/WebKit/chromium/tests/CCQuadCullerTest.cpp:48 > + m_stack.last().surface = 0; Can you enforce that StackObject doesn't leave surface uninitialized so this doesn't happen again? Maybe add a default constructor that initializes to null and some other constructor that initializes to some other surface? (In reply to comment #3) > (From update of attachment 131847 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131847&action=review > > > Source/WebKit/chromium/tests/CCQuadCullerTest.cpp:48 > > + m_stack.last().surface = 0; > > Can you enforce that StackObject doesn't leave surface uninitialized so this doesn't happen again? Maybe add a default constructor that initializes to null and some other constructor that initializes to some other surface? Yup! Done. Created attachment 131874 [details]
Patch
Comment on attachment 131874 [details]
Patch
Thanks! R=me
Comment on attachment 131874 [details] Patch Clearing flags on attachment: 131874 Committed r110878: <http://trac.webkit.org/changeset/110878> All reviewed patches have been landed. Closing bug. |