Bug 81017

Summary: Revert RenderLayer::absoluteBoundingBox to an IntRect
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, jchaffraix, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Levi Weintraub
Reported 2012-03-13 11:55:16 PDT
RenderLayer::absoluteBoundingBox represents a layer's box in application coordinates and is used mostly by platform code. This change pixel snaps the rect and returns it as an IntRect to avoid exposing sub-pixel units to platform code, and because absolute coordinates make more senes to be in pixels (see also absoluteRects, which uses IntRect).
Attachments
Patch (3.44 KB, patch)
2012-03-13 12:16 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2012-03-13 12:16:22 PDT
Created attachment 131690 [details] Patch
Eric Seidel (no email)
Comment 2 2012-03-13 12:17:16 PDT
Comment on attachment 131690 [details] Patch OK.
Levi Weintraub
Comment 3 2012-03-13 12:17:47 PDT
Comment on attachment 131690 [details] Patch Thanks Eric :)
WebKit Review Bot
Comment 4 2012-03-13 15:53:50 PDT
Comment on attachment 131690 [details] Patch Clearing flags on attachment: 131690 Committed r110629: <http://trac.webkit.org/changeset/110629>
WebKit Review Bot
Comment 5 2012-03-13 15:53:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.