Bug 81001 – [BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Konrad Piascik]

Chromium does this in bug 62149.  BlackBerry will add its own implementation in the hopes that once the 2 ports have visibility into each other's code that bug 79100 will be easier to address.

[Konrad Piascik]

Created attachment 144882 [details]
Patch

[Arvid Nilsson]

Comment on attachment 144882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144882&action=review

> Source/WebKit/ChangeLog:3
> +        [BlackBerry] Add and Accelerated Compositing layer for Web Inspector DOM highlight.

I think it should be "an accelerated..."

> Source/WebKit/blackberry/ChangeLog:3
> +        [BlackBerry] Add and Accelerated Compositing layer for Web Inspector DOM highlight.

Same here

> Source/WebKit/blackberry/Api/WebPage_p.h:431
> +#endif

I think this is a remnant from an earlier version of the patch, that you should remove.

[Arvid Nilsson]

Otherwise looks good, I see you added a line to updateDelegatedOverlays, I hope it follows along with accelerated animations now...

[Konrad Piascik]

update summary

[Konrad Piascik]

Created attachment 144897 [details]
Patch

[Antonio Gomes]

Comment on attachment 144897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144897&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:6348
> +    }
> +
> +}

r- extra line :)

[Konrad Piascik]

Created attachment 144911 [details]
Patch

[WebKit Review Bot]

Comment on attachment 144911 [details]
Patch

Clearing flags on attachment: 144911

Committed r119046: <http://trac.webkit.org/changeset/119046>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.