Summary: | [BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Konrad Piascik <kpiascik> | ||||||||
Component: | WebKit BlackBerry | Assignee: | Konrad Piascik <kpiascik> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | anilsson, rakuco, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 79100 | ||||||||||
Attachments: |
|
Description
Konrad Piascik
2012-03-13 09:07:19 PDT
Created attachment 144882 [details]
Patch
Comment on attachment 144882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144882&action=review > Source/WebKit/ChangeLog:3 > + [BlackBerry] Add and Accelerated Compositing layer for Web Inspector DOM highlight. I think it should be "an accelerated..." > Source/WebKit/blackberry/ChangeLog:3 > + [BlackBerry] Add and Accelerated Compositing layer for Web Inspector DOM highlight. Same here > Source/WebKit/blackberry/Api/WebPage_p.h:431 > +#endif I think this is a remnant from an earlier version of the patch, that you should remove. Otherwise looks good, I see you added a line to updateDelegatedOverlays, I hope it follows along with accelerated animations now... update summary Created attachment 144897 [details]
Patch
Comment on attachment 144897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144897&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:6348 > + } > + > +} r- extra line :) Created attachment 144911 [details]
Patch
Comment on attachment 144911 [details] Patch Clearing flags on attachment: 144911 Committed r119046: <http://trac.webkit.org/changeset/119046> All reviewed patches have been landed. Closing bug. |